Skip to content

Always set BuildingInsideVisualStudio when loading MSBuild workspace #57219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoeRobich wants to merge 1 commit into from
Closed

Always set BuildingInsideVisualStudio when loading MSBuild workspace #57219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/Workspaces/Core/MSBuild/MSBuild/Build/ProjectBuildManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,7 @@ internal class ProjectBuildManager
{ PropertyNames.DesignTimeBuild, bool.TrueString },

// this will force CoreCompile task to execute even if all inputs and outputs are up to date
#if NETCOREAPP
Copy link
Member

@jasonmalinowski jasonmalinowski Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be an almost direct revert of #40885; does this reintroduce whatever original issue that was fixing?

Copy link
Member

@jasonmalinowski jasonmalinowski Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharwell can you clarify what the original change was for?

Copy link
Contributor

@sharwell sharwell Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were hitting dotnet/msbuild#4770, presumably because dotnet/msbuild#5045 wasn't available in one or more SDKs we were executing against.

{ PropertyNames.NonExistentFile, "__NonExistentSubDir__\\__NonExistentFile__" },
Copy link
Member

@jasonmalinowski jasonmalinowski Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR introduced this property name, can we delete it again?

#else
// Setting `BuildingInsideVisualStudio` indirectly sets NonExistentFile:
// https://github.com/microsoft/msbuild/blob/ab9b2f36a5ff7a85f842b205d5529e77fdc9d7ab/src/Tasks/Microsoft.Common.CurrentVersion.targets#L3462-L3470
{ PropertyNames.BuildingInsideVisualStudio, bool.TrueString },
#endif

{ PropertyNames.BuildProjectReferences, bool.FalseString },
{ PropertyNames.BuildingProject, bool.FalseString },
Expand Down