Skip to content

Test MSBuildWorkspace opening dotnet new projects. #69225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoeRobich merged 17 commits into from
Feb 12, 2024
Merged

Test MSBuildWorkspace opening dotnet new projects. #69225

JoeRobich merged 17 commits into from
Feb 12, 2024

Conversation

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jul 26, 2023 •
edited
Loading

dotnet-format uses MSBuildWorkspace and needs to support the common .NET SDK scenarios, including WPF.

  • Adds the MSBuildWorkspace loader tests from dotnet/format
  • Adds the ability for the ProjectBuildManager to run targets when they are supported. Such as DesignTimeMarkupCompilation to support WPF scenarios.

Fixes dotnet/format#1402

@JoeRobich JoeRobich requested review from a team as code owners July 26, 2023 01:23
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 26, 2023
sharwell
sharwell reviewed Jul 26, 2023
View reviewed changes
@JoeRobich
Copy link
Member Author

JoeRobich commented Jul 26, 2023

Thanks for the review @sharwell! I have updated with your suggestions.

sharwell
sharwell reviewed Jul 26, 2023
View reviewed changes
src/Workspaces/Core/MSBuild/MSBuild/Build/ProjectBuildManager.cs

var targets = new[] { TargetNames.Compile, TargetNames.CoreCompile };
var requiredTargets = new[] { TargetNames.Compile, TargetNames.CoreCompile };
var optionalTargets = new[] { TargetNames.DesignTimeMarkupCompilation };
Copy link
Contributor

@sharwell sharwell Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 It looks like if we set BuildingInsideVisualStudio to true, this will run automatically

Copy link
Member Author

@JoeRobich JoeRobich Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge in the changes from #57219 and close that one out.

Copy link
Member Author

@JoeRobich JoeRobich Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, after testing locally, setting BuildingInsideVisualStudio breaks the blazor and blazorwasm scenarios. Will have to dig a bit to understand why.

Copy link
Member Author

@JoeRobich JoeRobich Jul 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharwell Setting BuildingInsideVisualStudio causes the RazorSourceGenerator.razorencconfig file to be added as an AnalyzerConfig, which then adds build_property.SuppressRazorSourceGenerator = true to the configuration. I noticed Roslyn's feature layer has a class dedicated to removing this config file from the Solution (https://github.com/dotnet/roslyn/blob/f5b6c715a742c56b7cc672e47385508fb4df98cc/src/Features/Core/Portable/Workspace/CompileTimeSolutionProvider.cs). I think we should take the change as is until Razor has sorted out their design time build.

Copy link
Member Author

@JoeRobich JoeRobich Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidwengier Do you know the status of the Razor design time build work?

Copy link
Member

@davidwengier davidwengier Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There won't be any change Razor design time code gen in the short term.
Additionally the last time someone tried to change whether BuildingInsideVisualStudio was set it broke dotnet watch and various VS Code things, from memory.

@JoeRobich JoeRobich mentioned this pull request Aug 22, 2023
Closed
@JoeRobich JoeRobich force-pushed the dev/jorobich/msbuildworkspace-wpf-support branch from 23db666 to 183fada Compare September 20, 2023 23:52
jasonmalinowski
jasonmalinowski reviewed Oct 19, 2023
View reviewed changes
@JoeRobich JoeRobich force-pushed the dev/jorobich/msbuildworkspace-wpf-support branch from e437a14 to c3b7a08 Compare January 23, 2024 01:19
jasonmalinowski
jasonmalinowski reviewed Jan 25, 2024
View reviewed changes
jasonmalinowski
jasonmalinowski reviewed Jan 25, 2024
View reviewed changes
@dibarbet dibarbet mentioned this pull request Feb 8, 2024
Closed
jasonmalinowski
jasonmalinowski reviewed Feb 9, 2024
View reviewed changes
@JoeRobich
Test MSBuildWorkspace project loading against dotnet project templates
9c99675
@JoeRobich
Update ProjectBuildManager to optionally run MarkupCompilation.
20ba0dd
@JoeRobich
Update OpenProjectsTests to report unnecessarily ignored diagnostics
6eaa4a4
@JoeRobich
Remove unnecessary ignored diagnostics from wpf tests
4191b8c
@JoeRobich
Use DisposableDirectory for test project cleanup.
62db227
@JoeRobich
Make ignoredDiagnostics optional in OpenProjectsTests
7fe7320
@JoeRobich
Remove msBuildPath from DotNetSdkLocator
8e6d5cd
@JoeRobich
Change how global.json is located to account for Helix layout.
ac074ee 
The DotNetSdkLocator was coded to expect the the normal development
layout of files, the test assembly is deeply nested under /artifacts.
The Helix layout is quite different with test assemblies nested much
shallower. Workspacese need to support both environments and this
can be acheived by walking up the filesystem from the test assembly.
@JoeRobich
Use system install of dotnet CLI when running in Helix.
97f8267
@JoeRobich
Address PR feedback.
8130b7b
@JoeRobich
Added ignore diagnostic to VB test when not run on Windows.
f0edf9c
@JoeRobich
PR Feedback
920dc61
This was referenced Feb 9, 2024
Open
Closed
@JoeRobich JoeRobich force-pushed the dev/jorobich/msbuildworkspace-wpf-support branch from 0fe481c to 29ec1ac Compare February 9, 2024 03:05
jasonmalinowski
jasonmalinowski approved these changes Feb 10, 2024
View reviewed changes
@JoeRobich JoeRobich enabled auto-merge February 12, 2024 21:30
@JoeRobich JoeRobich disabled auto-merge February 12, 2024 21:50
@JoeRobich JoeRobich mentioned this pull request Feb 12, 2024
Open
@JoeRobich JoeRobich merged commit d8f4c5e into main Feb 12, 2024
@ghost ghost added this to the Next milestone Feb 12, 2024
@jjonescz jjonescz modified the milestones: Next, 17.10 P2 Feb 27, 2024
@filzrev filzrev mentioned this pull request Mar 16, 2024
Open
@JoeRobich JoeRobich deleted the dev/jorobich/msbuildworkspace-wpf-support branch May 7, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier left review comments

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

+1 more reviewer

@sharwell sharwell sharwell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.10 P2

Development

Successfully merging this pull request may close these issues.

Template generated Projects fail to load cleanly

6 participants

@JoeRobich @jasonmalinowski @davidwengier @sharwell @jjonescz