[Testing] Refactoring Feature Matrix UITest Cases for CheckBox Control

[LogishaSelvarajSF4525]

This pull request refactors and enhances the CheckBox feature matrix test page and its associated ViewModel. The main changes include renaming and simplifying the ViewModel, adding support for a shadow property on the CheckBox, improving the reset logic, and updating the UI and test constants to match these changes.

ViewModel Refactoring and Enhancement:

• Renamed CheckBoxFeatureMatrixViewModel to CheckBoxViewModel, moved the color-setting logic into the ViewModel, and added a new Reset() method to centralize state resets. The ViewModel now also exposes a HasShadow property and a corresponding Shadow property, allowing the CheckBox to visually display a shadow when toggled. [1] [2] [3]

UI and Binding Updates:

• Updated CheckBoxControlPage.xaml to use the new ViewModel name, bind the CheckBox's Shadow property, and add a UI toggle for the shadow feature. The reset button now calls the ViewModel's Reset() method. The color buttons were updated with text, color, and width for clarity. [1] [2] [3]

Logic and Usability Improvements:

• The Switch controlling IsChecked is now disabled when the CheckBox is disabled, ensuring consistent behavior and preventing user interaction when not allowed.

Test Constants Update:

• Added new automation IDs and constants in the test file to support the new UI elements (HasShadowCheckBox, color buttons, and command parameter entry).

Code Cleanup:

• Removed unused commands and redundant code from the code-behind, delegating all state logic to the ViewModel for a cleaner separation of concerns.

These changes improve maintainability, testability, and feature coverage for the CheckBox control in the test app.

Issues Identified

• [iOS] Color of the checkBox control is not properly worked on dynamic scenarios #34278

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34283

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34283"

[sheiksyedm]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Copilot]

Pull request overview

This PR refactors the CheckBox FeatureMatrix test page and updates the corresponding FeatureMatrix UITests to match, including adding a “shadow” toggle and improving reset/state handling for more scenarios around checked/enabled/command/color behavior (related to #34278).

Changes:

• Refactored the FeatureMatrix ViewModel (CheckBoxFeatureMatrixViewModel → CheckBoxViewModel), moved color/shadow/reset logic into the VM, and simplified code-behind.
• Updated the CheckBox FeatureMatrix page bindings/UI (new shadow toggle, shadow binding, updated reset behavior, updated color buttons and AutomationIds).
• Expanded/reworked the FeatureMatrix UI tests and added an Android snapshot for CheckBox_VerifyColorAfterReset.

Reviewed changes

Copilot reviewed 4 out of 14 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/CheckBoxFeatureTests.cs	Reworked and expanded CheckBox FeatureMatrix UITests; added ordering and new scenarios (shadow/commands/reset/color).
src/Controls/tests/TestCases.HostApp/FeatureMatrix/CheckBox/CheckBoxViewModel.cs	New simplified ViewModel with centralized reset, color command, and shadow support.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/CheckBox/CheckBoxControlPage.xaml.cs	Simplified code-behind; reset now delegates to VM; removed redundant command wiring.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/CheckBox/CheckBoxControlPage.xaml	Updated bindings/UI to use new VM, bind Shadow, add shadow toggle, and adjust color/reset UI.
src/Controls/tests/TestCases.Android.Tests/snapshots/android/CheckBox_VerifyColorAfterReset.png	Added/updated Android baseline image for the new/updated screenshot test.

[sheiksyedm]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kubaflo]

🤖 AI Summary

📊 Expand Full Review

---

🔍 Pre-Flight — Context & Validation

---

📝 Review Session — updated the sample · 371d871

---

PR: #34283 - [Testing] Refactoring Feature Matrix UITest Cases for CheckBox Control
Issue: #34278 - [iOS] Color of the checkBox control is not properly worked on dynamic scenarios
Platforms Affected: iOS, MacCatalyst (issue), plus All platforms (for test refactoring)
Files Changed: 4 implementation/test files + 10 snapshot PNG files

Issue Summary

When CheckBox Color is set to null dynamically on iOS/MacCatalyst, the CheckBox retains the previously applied color instead of reverting to the default color. This is a visual regression on iOS 18 and iOS 26.

PR Type

Testing-only PR - This PR refactors the CheckBox feature matrix test infrastructure and adds new test cases. It does NOT include a production code fix. The test that reproduces the actual bug (CheckBox_VerifyColorAfterReset) is intentionally disabled on iOS/Catalyst with #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST.

Files Changed

Implementation/Test files:

• src/Controls/tests/TestCases.HostApp/FeatureMatrix/CheckBox/CheckBoxViewModel.cs - Renamed from CheckBoxFeatureMatrixViewModel, added Reset(), HasShadow/Shadow properties, moved color logic into ViewModel
• src/Controls/tests/TestCases.HostApp/FeatureMatrix/CheckBox/CheckBoxControlPage.xaml - Updated bindings for new ViewModel, added shadow toggle, used UITestEntry with IsCursorVisible="False", added color buttons with text/color/width
• src/Controls/tests/TestCases.HostApp/FeatureMatrix/CheckBox/CheckBoxControlPage.xaml.cs - Simplified code-behind, delegates state to ViewModel via Reset()
• src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/CheckBoxFeatureTests.cs - Added new tests, WaitForElement for stability, shadow test, color after reset (guarded by #if)

Snapshot baselines (10 files): Android, iOS, Mac, modified existing + added new shadow/reset screenshotsWindows

Key Findings

• All previous review comments (from copilot-pull-request-reviewer) have been marked as resolved by the author:
  fixed
  fixed
  fixed
  fixed (now uses UITestEntry with IsCursorVisible="False")
  fixed

• Important Design Decision in XAML: IsCheckedSwitch is now bound to IsEnabled="{Binding IsEnabled}", preventing users from changing IsChecked via the Switch when the CheckBox is disabled. This is intentional per comment in XAML.

• The bug test CheckBox_VerifyColorAfterReset is wrapped in #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_ meaning it's disabled until the actual production fix lands in a separate PR.CATALYST

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #34283	Refactor test infrastructure: rename ViewModel, add Reset(), shadow support, UITestEntry, new test PENDING (Gate)	4 code files + 10 snapshots	Testing-only PR	cases

---

🚦 Gate — Test Verification

---

📝 Review Session — updated the sample · 371d871

---

Result PASSED:
Platform: ios
Mode: Full Verification
Test Filter: CheckBox_VerifyWithShadow

• Tests FAIL without fix
• Tests PASS with fix

Note: This is a testing-only PR (refactoring + new test cases). The CheckBox_VerifyWithShadow test is a newly added test in the PR. Without the PR's changes, the test fails (the ViewModel/page structure doesn't support shadow). With the PR's changes, the test passes.

---

🔧 Fix — Analysis & Comparison

---

📝 Review Session — updated the sample · 371d871

---

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix (claude-sonnet-4.6)	Add in CheckBoxExtensions.cs	PASS	2 files (+VisualRegressionTester fix + snapshot)	Simplest fix
2	try-fix (claude-opus-4.6)	Use via PaintExtensions (single line, no if/else)	PASS	2 files + snapshot	Elegant, handles all Paint types
3	try-fix (gpt-5.2)	Capture default TintColor in MauiCheckBox constructor + method	PASS	3 files + snapshot	More invasive, adds state to MauiCheckBox
4	try-fix (gpt-5.3-codex)	Clear tint in CheckBoxHandler.iOS.cs MapForeground before FAIL	2 files	Failed: compile error (missing VisualRegressionTester fallbackEnvironmentName param)	UpdateForeground
5	try-fix (gemini-3-pro-preview)	Handler approach + compile fix for FAIL	2 files	Failed: test run failed (exit code 1)	VisualRegressionTester
PR	PR #34283	Test infrastructure refactoring no production fix. intentionally disabled on iOS.	only PASS (Gate)	4 code files + 10 snapshots	Testing-only PR

Cross-Pollination (Round 2)

Model	Response
claude-sonnet-4.6	NEW IDEA: Fix CheckBoxTintUIColor getter use TintColor (iOS inherited) instead of hardcoded UIColor.White
claude-opus-4.6	NO NEW IDEAS
gpt-5.2	NEW IDEA: Map CheckBox.Color directly to UIView.TintColor for natural tint inheritance
gpt-5.3-codex	NEW IDEA: Recreate MauiCheckBox when Color transitions from non-null to null
gemini-3-pro-preview	NEW IDEA: Override MapForeground in handler with explicit null check (variant of attempts 4/5)

No additional try-fix rounds new ideas from models 1, 3, 4 were either too invasive (recreate MauiCheckBox), variants of failed handler approaches, or supplementary improvements (not core fixes). The fix space for the root cause is exhausted with 3 passing candidates.run

Exhausted: all 5 models queried in Round 2; no viable new independent approach remainsYes
Selected Fix: PR's This is a [Testing] refactoring PR by design. The PR author intentionally did NOT include a production fix and instead disabled the failing test with #if TEST_FAILS_ON_IOS. The test infrastructure quality is high (all reviewer comments addressed). The production fix for #34278 should come in a separate PR. Among try-fix alternatives, Attempt 2 (PaintExtensions.ToColor()) is cleanest but does not change the recommendation.fix

Root Cause (for reference)

UpdateForeground in CheckBoxExtensions.cs only handles whenCheckBox.Coloris set tonull, the else/null case is not handled so CheckBoxTintColor is never reset on the platform view, retaining the old color.SolidPaint

Simplest fix (when ready): Replace the conditional with:

platformCheckBox.CheckBoxTintColor = check.Foreground.ToColor();

---

📋 Report — Final Recommendation

---

📝 Review Session — updated the sample · 371d871

---

Final Recommendation: APPROVE

Summary

PR #34283 is a well-executed refactoring PR that improves the CheckBox feature matrix test infrastructure. The PR renames the ViewModel, centralizes state in a method, adds shadow support testing, uses for screenshot stability, and adds comprehensive test coverage. All previous reviewer comments have been addressed. Gate PASSED on iOS.

The PR intentionally does NOT fix the production iOS color bug (# the failing test is correctly disabled with #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST and a link to the issue. This is an acceptable design pattern (ship test infrastructure before the fix).34278)

---

Root Cause (Issue #34278, not fixed in this PR)

UpdateForeground in CheckBoxExtensions.cs (iOS) only handles whenCheckBox.Coloris set tonull, the else/null case is not handled so CheckBoxTintColor is never reset on the platform view.SolidPaint

Fix Quality (Test Infrastructure Changes)

Excellent. The refactoring is clean and addresses all reviewer feedback:

• ViewModel correctly uses INotifyPropertyChanged with Reset() centralizing state
• UITestEntry with IsCursorVisible="False" for screenshot stability
• WaitForElement added before all element interactions
• VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2)) used correctly
• CheckBox_VerifyColorAfterReset disabled on iOS/Catalyst with issue link comment

---

PR Finalization (Title & Description)

Title Assessment: Acceptable but could be slightly more descriptive.

• Current: [Testing] Refactoring Feature Matrix UITest Cases for CheckBox Control
• Suggested: [Testing] CheckBox: Refactor Feature Matrix tests (ViewModel, shadow, Reset, color tests)

Description Assessment: Moderately detailed. The sections accurately describe the changes.

Missing required NOTE Must be prepended:block

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you!

---

Code Review Findings

**

1. CheckBox_SetAllProperties_VerifyVisualState (Order 15) adds limited value

   • Sets green color, disables CheckBox, taps it, asserts IsCheckedLabel is "True"
   • The assertion "True" is trivially satisfied since IsChecked started at True and tapping disabled doesn't change it
   • Consider adding a screenshot or stronger assertion, or removing if covered by other tests

2. OnCheckBoxCheckedChanged fires on programmatic IsChecked changes

   • CheckedChanged fires when IsCheckedSwitch toggles the binding, not only direct user taps
   • Tests that use IsCheckedSwitch will incidentally set CheckedChangedStatus
   • This is mitigated by Reset() at the start of each test but worth documenting

** Looks Good**

Shadow property chain in ViewModel is clean

• IsCheckedSwitch correctly disabled when IsEnabled=false (prevents misleading state)
• All test orders make sense and tests are independent via Reset()
• CheckBox_VerifyCheckedChangedEvent correctly verifies the event doesn't fire when disabled
• Unused removed , unused removed

---

Note on Production Fix Availability

Try-fix found a one-line production fix for issue #34278 that could optionally be included in this PR or a follow-up:

// In src/Core/src/Platform/iOS/CheckBoxExtensions.cs
public static void UpdateForeground(this MauiCheckBox platformCheckBox, ICheckBox check)
{
    // Replace the if-block with:
    platformCheckBox.CheckBoxTintColor = check.Foreground.ToColor();
    // This handles null Foreground (returns null, resetting tint) and SolidPaint (extracts color)
}

If included, the #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST guard should be removed and iOS/Catalyst snapshots added for CheckBox_VerifyColorAfterReset.

---

📋 Expand PR Finalization Review

---

Title: ✅ Good

Current: [Testing] Refactoring Feature Matrix UITest Cases for CheckBox Control

Description: ✅ Good

Description needs updates. See details below.

✨ Suggested PR Description

[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

This pull request refactors and enhances the CheckBox feature matrix test page and its associated ViewModel. The main changes include renaming and simplifying the ViewModel, adding support for a shadow property on the CheckBox, improving the reset logic, and updating the UI and test constants to match these changes.

ViewModel Refactoring and Enhancement:

• Renamed CheckBoxFeatureMatrixViewModel to CheckBoxViewModel, moved the color-setting logic into the ViewModel, and added a new Reset() method to centralize state resets. The ViewModel now also exposes a HasShadow property and a corresponding Shadow property, allowing the CheckBox to visually display a shadow when toggled. [1] [2] [3]

UI and Binding Updates:

• Updated CheckBoxControlPage.xaml to use the new ViewModel name, bind the CheckBox's Shadow property, and add a UI toggle for the shadow feature. The reset button now calls the ViewModel's Reset() method. The color buttons were updated with text, color, and width for clarity. [1] [2] [3]
• Replaced deprecated StackLayout with VerticalStackLayout/HorizontalStackLayout throughout the page.
• Replaced Entry with UITestEntry (with IsCursorVisible="False") for the command parameter field to prevent cursor blinking from causing flaky screenshot comparisons.

Logic and Usability Improvements:

• The Switch controlling IsChecked is now disabled when the CheckBox is disabled, ensuring consistent behavior and preventing user interaction when not allowed.

Test Constants Update:

• Added new automation IDs and constants in the test file to support the new UI elements (HasShadowCheckBox, color buttons, and command parameter entry).
• Moved [Category(UITestCategories.CheckBox)] to the class level and added [Test, Order(N)] ordering to all tests.
• Added 9 new test cases covering shadow rendering, command execution with parameters (checked/unchecked states), event+command simultaneous execution, direct tap toggle, reset verification, and disabled-state checks.

Known Issue (not fixed in this PR):

• CheckBox_VerifyColorAfterReset is guarded behind #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST because on iOS/MacCatalyst the CheckBox color is not properly reset when set back to null dynamically. This test documents the known behavior but is skipped on affected platforms to avoid blocking CI.

Code Cleanup:

• Removed unused commands and redundant code from the code-behind, delegating all state logic to the ViewModel for a cleaner separation of concerns.
• Removed the partial class CheckBoxFeatureMatrixViewModel extension from the code-behind file that previously hosted SetColorCommand.

These changes improve maintainability, testability, and feature coverage for the CheckBox control in the test app.

Issues Fixed

Related to #34278 (iOS CheckBox color not properly reset — documented with skipped test, bug not yet fixed)

Code Review: ✅ Passed

Code Review — PR #34283

🟡 Suggestions

---

1. CheckBox_VerifyCommandWithParameterWhileUnChecked (Order 8) — Implicit Command Behavior

File: src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/CheckBoxFeatureTests.cs

Code:

[Test, Order(8)]
public void CheckBox_VerifyCommandWithParameterWhileUnChecked()
{
    App.WaitForElement(ResetButton);
    App.Tap(ResetButton);                          // Reset() → CommandStatus = ""
    App.WaitForElement(CommandParameterEntry);
    App.EnterText(CommandParameterEntry, "TestParameter");
    App.DismissKeyboard();
    App.WaitForElement(IsCheckedSwitch);
    App.Tap(IsCheckedSwitch);                      // Tapping Switch changes IsChecked via binding
    Assert.That(App.FindElement(CommandStatusLabel).GetText(), Is.EqualTo("Command Executed: TestParameter"));
    // ↑ Assertion passes only if MAUI CheckBox fires its Command on programmatic IsChecked changes
    App.WaitForElement(CheckBoxControl);
    App.Tap(CheckBoxControl);
    Assert.That(App.FindElement(CommandStatusLabel).GetText(), Is.EqualTo("Command Executed: TestParameter"));
}

Concern: The first assertion (after App.Tap(IsCheckedSwitch)) succeeds only if MAUI's CheckBox.Command fires when IsChecked is changed via two-way binding from the Switch — i.e., when a programmatic/binding-driven change occurs rather than a direct user tap of the CheckBox. This is non-obvious behavior (most controls only fire Command on direct user interaction).

If this is intentional (verifying that MAUI CheckBox fires Command on any IsChecked change), a brief comment would help future readers understand why the assertion is valid without having to trace the binding chain.

Recommendation: Add a comment explaining the intent:

// Tapping the Switch changes IsChecked via two-way binding.
// MAUI CheckBox fires its Command whenever IsChecked changes, even programmatically.
// This verifies the command fires correctly when the checkbox is unchecked this way.
App.Tap(IsCheckedSwitch);
Assert.That(App.FindElement(CommandStatusLabel).GetText(), Is.EqualTo("Command Executed: TestParameter"));

---

2. DefaultColorButton Constant is Unused in Tests

File: src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/CheckBoxFeatureTests.cs

Code:

const string DefaultColorButton = "DefaultColorButton";

Concern: DefaultColorButton is declared as a constant but is not used in any test method. The CheckBox_VerifyColorAfterReset test (which would logically use it to set then reset color) uses GreenColorButton + ResetButton (via ViewModel.Reset()) instead. The DefaultColorButton exists in the UI (calling SetColorCommand with null parameter → Color = null) but isn't exercised.

Recommendation: Either add a test that uses DefaultColorButton to verify that clicking "Default" resets color, or remove the unused constant.

---

3. Verbose Explanatory Comment in XAML

File: src/Controls/tests/TestCases.HostApp/FeatureMatrix/CheckBox/CheckBoxControlPage.xaml

Code:

<!-- This change is intentional. When IsEnabled is set to false, the CheckBox should not update IsChecked if the user taps it. To maintain consistent behavior, I also disabled the IsChecked Switch -->
<VerticalStackLayout>
    <HorizontalStackLayout >
        <Label Text="IsChecked" .../>
        <Switch IsToggled="{Binding IsChecked}"
                IsEnabled="{Binding IsEnabled}"
                AutomationId="IsCheckedSwitch"/>
    </HorizontalStackLayout>

Concern: A lengthy explanatory comment in XAML about implementation rationale is not idiomatic. XAML comments are preserved in source but can't be easily found by future developers. This kind of note is better suited for a commit message or PR description.

Recommendation: Shorten to a brief one-liner or remove entirely since the IsEnabled="{Binding IsEnabled}" binding is self-documenting:

<!-- IsChecked Switch is disabled when CheckBox is disabled (consistent UX) -->

---

✅ Looks Good

• ViewModel cleanup: Moving SetColorCommand into the ViewModel (removing the partial class extension in code-behind) is a clear improvement in separation of concerns.
• Reset() method: Correctly resets all state, including HasShadow (which cascades to set Shadow = null via the property chain). The indirect reset of IsEventStatusLabelVisible / IsCommandStatusLabelVisible through the status string setters is clever and correct.
• HasShadow/Shadow property chain: Well-implemented — HasShadow setter creates/clears the Shadow object and fires OnPropertyChanged for itself; Shadow setter fires its own OnPropertyChanged separately. Both bindings will update correctly.
• StackLayout → VerticalStackLayout/HorizontalStackLayout: Good improvement, avoids deprecated layout type.
• UITestEntry with IsCursorVisible="False": Correctly follows the pattern for screenshot-stable text input controls.
• [Category] at class level: Cleaner than per-test attributes; correct per repo conventions.
• #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST guard: Appropriate way to document a known platform bug without blocking CI. Issue [iOS] Color of the checkBox control is not properly worked on dynamic scenarios #34278 is correctly referenced in the test comment.
• Simplified null-check logic: IsEventStatusLabelVisible = !string.IsNullOrEmpty(value) is cleaner than the previous if (!string.IsNullOrEmpty(value)) { IsEventStatusLabelVisible = true; } (the old code never set it back to false!). This is actually a bug fix bundled in the cleanup.
• OnSetColor(null) handling: The XAML DefaultColorButton passes no CommandParameter (null), which hits the _ => null branch in the switch expression → Color = null. Correct behavior.

---