[iOS] SwipeView: Honor FontImageSource.Color in SwipeItem icon

[kubaflo]

Description of Change

Replaced UIImageRenderingMode.AlwaysTemplate with UIImageRenderingMode.Automatic

Issues Fixed

Fixes #27377

[dotnet-policy-service]

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[kubaflo]

@jsuarezruiz can you please /azp again?

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[kubaflo]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kubaflo]

🤖 AI Summary

📊 Expand Full Review

---

🔍 Pre-Flight — Context & Validation

---

📝 Review Session — Update SwipeItemMenuItemHandler.iOS.cs · 385a3c2

---

Issue: #27377 - [iOS] SwipeView: SwipeItem.IconImageSource.FontImageSource color value not honored
PR: #27389 - [iOS] SwipeView: Honor FontImageSource.Color in SwipeItem icon
Author: kubaflo (Jakub Florkowski) - Community Contributor
Platforms Affected: iOS (also MacCatalyst — same .iOS.cs handler)
Files Changed: 1 implementation file, 3 test files, 3 snapshot images

Note: This is a resumed review. A prior full 4-phase agent review was completed and posted as a PR comment. The author has since updated the implementation to match the agent's recommended Attempt 1 fix (AlwaysTemplate + TintColor from FontImageSource.Color). This review re-validates the updated implementation.

Issue Summary

When using a SwipeItem with a FontImageSource for icon on iOS, the specified Color is not applied. The icon renders in the iOS system blue color instead of the user-specified color (e.g., Red). This is a regression from Xamarin.Forms behavior.

Root cause: SwipeItemMenuItemHandler.iOS.cs unconditionally applied UIImageRenderingMode.AlwaysTemplate to all swipe item icons, then tinted them using only item.GetTextColor(). When GetTextColor() returns null, iOS falls back to the inherited system blue tint, ignoring any FontImageSource.Color.

Files Classified

Fix files:

• src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs - Now uses AlwaysTemplate + conditionally sets button.TintColor = fontImageSource.Color.ToPlatform() when FontImageSource has explicit color

Test files:

• src/Controls/tests/TestCases.HostApp/Issues/Issue27377.xaml - SwipeView repro page with Ionicons font, red color
• src/Controls/tests/TestCases.HostApp/Issues/Issue27377.xaml.cs - Code-behind, opens right items on button click
• src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27377.cs - Screenshot comparison test (Android || iOS)

Snapshot files:

• src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/FontImageSourceShouldHonorColor.png
• src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/FontImageSourceShouldHonorColor.png
• src/Controls/tests/TestCases.Android.Tests/snapshots/android/FontImageSourceShouldHonorColor.png

Updated Implementation (Since Prior Review)

The last commit ("Update SwipeItemMenuItemHandler.iOS.cs") changed the implementation from the original PR's UIImageRenderingMode.Automatic to:

button.SetImage(resizedImage.ImageWithRenderingMode(UIImageRenderingMode.AlwaysTemplate), UIControlState.Normal);

if (item.Source is IFontImageSource fontImageSource && fontImageSource.Color != null)
    button.TintColor = fontImageSource.Color.ToPlatform();
else
{
    var tintColor = item.GetTextColor();
    if (tintColor != null)
        button.TintColor = tintColor.ToPlatform();
}

This matches exactly the agent's recommended Attempt 1 from the prior try-fix exploration.

Prior Review Discussion Summary

File:Line	Reviewer Says	Status
SwipeItemMenuItemHandler.iOS.cs	Use AlwaysTemplate + route FontImageSource.Color to TintColor (Attempt 1)	✅ IMPLEMENTED
Issue27377.cs:24	Use retryTimeout instead of retryDelay	⚠️ NOT YET FIXED
Issue27377.xaml:5	Unused xmlns:ns namespace	⚠️ NOT YET FIXED
Issue27377.xaml:21	Glyph="T" may not render valid Ionicons glyph	⚠️ MINOR
Issue27377.cs:1	MacCatalyst not covered by `#if ANDROID

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #27389 (updated)	AlwaysTemplate + TintColor = fontImageSource.Color.ToPlatform() when FontImageSource has explicit color	⏳ PENDING (Gate)	SwipeItemMenuItemHandler.iOS.cs	Implements agent's recommended Attempt 1

---

🚦 Gate — Test Verification

---

📝 Review Session — Update SwipeItemMenuItemHandler.iOS.cs · 385a3c2

---

Result: ✅ PASSED
Platform: ios
Mode: Full Verification
Test Filter: Issue27377

• Tests FAIL without fix ✅ (bug confirmed present without fix)
• Tests PASS with fix ✅ (fix confirmed working)

Fix Files Verified:

• src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs

Verification artifacts: CustomAgentLogsTmp/PRState/27389/PRAgent/gate/verify-tests-fail/

---

🔧 Fix — Analysis & Comparison

---

📝 Review Session — Update SwipeItemMenuItemHandler.iOS.cs · 385a3c2

---

Fix Candidates

Note: A prior full try-fix exploration (8 attempts, 5 models, 3 rounds) was completed in the previous review session. The PR author has since implemented the agent's recommended fix (Attempt 1). The table below imports those results.

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix	Keep AlwaysTemplate; set button.TintColor = fontImageSource.Color.ToPlatform() when FontImageSource has explicit color	✅ PASS	SwipeItemMenuItemHandler.iOS.cs (+8/-3)	Recommended — minimal, explicit, most robust
2	try-fix	Use UIImageRenderingMode.AlwaysOriginal for FontImageSource with explicit color, AlwaysTemplate otherwise	✅ PASS	SwipeItemMenuItemHandler.iOS.cs (+11/-5)	Copilot reviewer suggested; also valid
3	try-fix	Preserve platformImage.RenderingMode from incoming image instead of forcing AlwaysTemplate	✅ PASS	SwipeItemMenuItemHandler.iOS.cs (+8/-3)	Source-type-agnostic; relies on upstream contract
4	try-fix	Pre-tint with CoreGraphics + AlwaysOriginal	❌ FAIL	—	Compile error (VisualRegressionTester missing fallbackEnvironmentName)
5	try-fix	Subclass SwipeItemButton with LayoutSubviews override; set ImageView.TintColor directly	✅ PASS	SwipeItemMenuItemHandler.iOS.cs (+21/-1)	More complex; adds new class hierarchy
6	try-fix	UIButtonType.Custom constructor + preserve incoming RenderingMode	✅ PASS	SwipeItemMenuItemHandler.iOS.cs (+4/-1)	Changes button type — broader behavioral impact
7	try-fix	UIImage.ImageWithTintColor(color, AlwaysOriginal) (UIKit built-in iOS 13+)	❌ FAIL	—	Not available in current iOS SDK bindings (CS1061)
8	try-fix	UIButton.Configuration with imageColorTransformer (iOS 15+)	❌ FAIL	—	Visual difference vs baseline (1.35%); layout/rendering engine differences
PR (original)	PR #27389 (original)	Conditionally use UIImageRenderingMode.Automatic for FontImageSource with explicit color	✅ PASS (Gate v1)	SwipeItemMenuItemHandler.iOS.cs (+13/-5)	Original; reviewer concern about Automatic reliability after bitmap resize
PR (updated)	PR #27389 (current)	AlwaysTemplate + TintColor = fontImageSource.Color.ToPlatform() when FontImageSource has explicit color	✅ PASS (Gate v2)	SwipeItemMenuItemHandler.iOS.cs	Implements Attempt 1 — validated by current Gate run

Cross-Pollination (Prior Session)

Round	Model	Response
Round 2	claude-sonnet-4.6	NO NEW IDEAS
Round 2	claude-opus-4.6	NO NEW IDEAS
Round 2	gpt-5.2	NEW IDEA: UIButtonType.Custom + preserve RenderingMode (→ Attempt 6)
Round 2	gpt-5.3-codex	NEW IDEA: UIImage.ImageWithTintColor (→ Attempt 7)
Round 2	gemini-3-pro-preview	NEW IDEA: UIButton.Configuration with imageColorTransformer (→ Attempt 8)
Round 3	claude-sonnet-4.6	NEW IDEA: Fix MaxResizeSwipeItemIconImage to re-apply rendering mode (variation of Attempt 3)
Round 3	claude-opus-4.6	NO NEW IDEAS
Round 3	gpt-5.2	NEW IDEA: Rasterize glyph with UIKit NSAttributedString (variation of failed Attempt 4)
Round 3	gpt-5.3-codex	NEW IDEA: Render glyph as attributed text title instead of UIImage
Round 3	gemini-3-pro-preview	NEW IDEA: UIGraphicsImageRenderer to bake color (variation of failed Attempt 4)

Exhausted: Yes (all 5 models confirmed no new distinct ideas by Round 3; remaining ideas were variations of already-tested approaches)

Selected Fix: PR's current fix (Attempt 1 implemented by author) — AlwaysTemplate + TintColor = fontImageSource.Color.ToPlatform()

Why Attempt 1 / current PR fix:

• Root cause clarity: Directly routes FontImageSource.Color to TintColor, which is exactly how iOS template image tinting is designed to work
• Consistent rendering mode: Always uses AlwaysTemplate — no conditional branching on rendering mode
• Avoids Automatic reliability concern: Automatic after MaxResizeSwipeItemIconImage creates a new bitmap UIImage (which has no rendering mode metadata); AlwaysTemplate is explicit and deterministic
• Minimal change: +8/-3 lines in one file
• Gate validated: ✅ PASS on current implementation

---

📋 Report — Final Recommendation

---

📝 Review Session — Update SwipeItemMenuItemHandler.iOS.cs · 385a3c2

---

✅ Final Recommendation: APPROVE

Summary

PR #27389 fixes a verified iOS bug where FontImageSource.Color is ignored for SwipeItem icons. After a prior review cycle that recommended changes, the author has implemented the agent's recommended fix (Attempt 1): keep UIImageRenderingMode.AlwaysTemplate and route FontImageSource.Color directly to TintColor. This is the correct, minimal, and most robust approach. Gate ✅ PASSED on the updated implementation (tests fail without fix, pass with fix).

The PR is ready to approve with minor suggestions noted below.

---

Root Cause

In SwipeItemMenuItemHandler.iOS.cs, SetImageSource unconditionally applied UIImageRenderingMode.AlwaysTemplate and then set TintColor only from item.GetTextColor(). When GetTextColor() returns null (no text color set), iOS falls back to the inherited system blue tint — ignoring any FontImageSource.Color specified by the developer. The fix correctly routes FontImageSource.Color to TintColor when present, which is exactly how iOS template image tinting is designed to work.

---

Fix Quality Assessment

What the PR now does (current implementation):

button.SetImage(resizedImage.ImageWithRenderingMode(UIImageRenderingMode.AlwaysTemplate), UIControlState.Normal);

if (item.Source is IFontImageSource fontImageSource && fontImageSource.Color != null)
    button.TintColor = fontImageSource.Color.ToPlatform();
else
{
    var tintColor = item.GetTextColor();
    if (tintColor != null)
        button.TintColor = tintColor.ToPlatform();
}

Why this is correct:

• Always uses AlwaysTemplate — no conditional rendering mode branching, avoids fragility after MaxResizeSwipeItemIconImage creates a new bitmap UIImage
• Directly routes FontImageSource.Color to TintColor — explicit iOS mechanism for coloring template images
• Preserves existing GetTextColor() tinting behavior for non-FontImageSource cases (no regression)

Gate: ✅ PASSED — tests fail without fix, pass with fix (ios platform)

---

pr-finalize Analysis

Title: ✅ Good

Current: [iOS] SwipeView: Honor FontImageSource.Color in SwipeItem icon

The title is accurate, descriptive, and uses the correct format. No change needed.

Description: ❌ Stale/Inaccurate — Needs Rewrite

Problem: The description still says "Replaced UIImageRenderingMode.AlwaysTemplate with UIImageRenderingMode.Automatic" — but the actual current implementation does NOT do this. The fix keeps AlwaysTemplate and adds conditional TintColor routing. This is factually incorrect and misleading.

Additionally missing:

• Required NOTE block
• Root cause explanation
• Accurate description of what changed

Suggested PR description:

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you!

### Root Cause

`SwipeItemMenuItemHandler.iOS.cs` applied `UIImageRenderingMode.AlwaysTemplate` to all SwipeItem icons, then tinted them using only `item.GetTextColor()`. When `GetTextColor()` returns null, iOS falls back to the inherited system blue tint, discarding any `FontImageSource.Color` the developer specified.

### Description of Change

When `item.Source` is an `IFontImageSource` with an explicit `Color`, the icon's `TintColor` is now set from `fontImageSource.Color.ToPlatform()` instead of only from `GetTextColor()`. The rendering mode remains `AlwaysTemplate` in all cases (avoiding fragility from `UIImageRenderingMode.Automatic` after `MaxResizeSwipeItemIconImage` creates a new bitmap UIImage). For all other image sources or when `FontImageSource.Color` is null, the original `GetTextColor()` tinting behavior is unchanged.

### What NOT to Do (for future agents)

- ❌ **Don't use `UIImageRenderingMode.Automatic` after `MaxResizeSwipeItemIconImage`** — this helper renders pixels via `cgcontext.DrawImage` into a `UIGraphicsImageRenderer`, creating a new bitmap UIImage with no rendering mode metadata. `Automatic` asks iOS to decide, which is fragile.
- ❌ **Don't use `UIImageRenderingMode.AlwaysOriginal`** — while it works, it bakes color into pixels. `AlwaysTemplate` + `TintColor` is simpler and uses the intended iOS API.

### Issues Fixed

Fixes https://github.com/dotnet/maui/issues/27377

---

Code Review Findings

🟡 Suggestions (Non-blocking)

Stale PR description (addressed above)

• File: PR body
• Problem: Says "Replaced AlwaysTemplate with Automatic" — no longer accurate after implementation update
• Recommendation: Update to the suggested description above

retryDelay should be retryTimeout

• File: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27377.cs:24
• Problem: retryDelay only changes the pause between retries but still retries once. retryTimeout continuously retries for the given duration, which is preferred for animation timing.
• Recommendation: VerifyScreenshot(retryTimeout: TimeSpan.FromSeconds(2))

Unused xmlns:ns namespace

• File: src/Controls/tests/TestCases.HostApp/Issues/Issue27377.xaml:5
• Problem: xmlns:ns="clr-namespace:Maui.Controls.Sample.Issues" is declared but never used
• Recommendation: Remove the unused namespace declaration to avoid XAML compiler warnings

MacCatalyst not covered by test guard

• File: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27377.cs:1
• Problem: #if ANDROID || IOS excludes MacCatalyst, but the fix is in .iOS.cs which compiles for both iOS and MacCatalyst
• Recommendation: Add MACCATALYST: #if ANDROID || IOS || MACCATALYST

Missing newline at end of files

• Files: Issue27377.xaml, Issue27377.xaml.cs, Issue27377.cs
• Problem: All three files lack a final newline
• Recommendation: Add newline at end of each file

✅ Looks Good

• Conditional check item.Source is IFontImageSource fontImageSource && fontImageSource.Color != null correctly identifies the color source
• else branch preserves existing GetTextColor() behavior — no regression on VerifySwipeViewApperance test
• Test structure is correct: waits for element, triggers swipe open, verifies screenshot
• Snapshots committed for both ios and ios-26 environments
• AlwaysTemplate rendering mode kept consistently — correct and explicit

---

Fix Candidates Summary

#	Approach	Result	Notes
PR (updated)	AlwaysTemplate + TintColor = fontImageSource.Color	✅ PASS (Gate)	Selected — optimal
1 (try-fix)	Same as current PR	✅ PASS	Agent recommended; now implemented
2 (try-fix)	AlwaysOriginal for FontImageSource with color	✅ PASS	Valid alternative
3 (try-fix)	Preserve incoming RenderingMode	✅ PASS	Clean but relies on upstream contract
5 (try-fix)	Subclass with LayoutSubviews override	✅ PASS	More complex
6 (try-fix)	UIButtonType.Custom + preserve RenderingMode	✅ PASS	Broader behavioral change
4, 7, 8 (try-fix)	Various alternative approaches	❌ FAIL	Compile errors or visual difference
PR (original)	UIImageRenderingMode.Automatic for FontImageSource	✅ PASS (Gate v1)	Fragile after bitmap resize — superseded

Selected Fix: PR's current fix (matches Attempt 1) — minimal, explicit, correct iOS pattern

---

📋 Expand PR Finalization Review

---

Title: ✅ Good

Current: [iOS] SwipeView: Honor FontImageSource.Color in SwipeItem icon

Description: ✅ Good

Description needs updates. See details below.
Missing Elements:

**

• ❌ Missing required NOTE block at top
• ❌ Missing root cause explanation
• ❌ Uses full URL for issue link instead of Fixes #27377

Recommendation: Full rewrite required. See recommended-description.md.

---

Phase 2: Code Review

See code-review.md for detailed findings.

Summary:

• 🟡 1 suggestion: test uses retryDelay where retryTimeout is preferred per UITest guidelines
• ✅ Core fix is correct and well-targeted
• ✅ Fallback to GetTextColor() is preserved for backward compatibility
• ✅ Android snapshot added for cross-platform visual regression coverage

✨ Suggested PR Description

[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause

On iOS, SwipeItemMenuItemHandler renders swipe item icons using UIImageRenderingMode.AlwaysTemplate, which applies a TintColor to colorize the image. Previously, TintColor was always sourced from item.GetTextColor(), ignoring any color specified directly on a FontImageSource. This meant that when users set FontImageSource.Color = "Red", the icon would display in the system default blue (or whatever text color was set), not the requested red.

Description of Change

In SwipeItemMenuItemHandler.iOS.cs (SetImageSource), the TintColor assignment now checks whether the image source is an IFontImageSource with an explicit color set:

• If item.Source is IFontImageSource and fontImageSource.Color != null → use fontImageSource.Color as TintColor
• Otherwise → fall back to item.GetTextColor() (existing behavior, unchanged)

The rendering mode remains AlwaysTemplate — this is intentional and required for tinting to work.

UI tests were added for both iOS and Android with screenshot verification to prevent regressions.

Issues Fixed

Fixes #27377

Code Review: ✅ Passed

Code Review — PR #27389

🟡 Suggestions

1. Prefer retryTimeout over retryDelay in UI test

File: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27377.cs

Current code:

App.WaitForElement("Action");
VerifyScreenshot(retryDelay: TimeSpan.FromSeconds(1));

Issue: Per the UITest guidelines, retryDelay only changes the delay between retries but only retries once. retryTimeout is the preferred parameter for handling animations with variable completion times — it keeps retrying until the timeout is reached.

Recommended:

App.WaitForElement("Action");
VerifyScreenshot(retryTimeout: TimeSpan.FromSeconds(2));

This is a minor issue and the current code may work fine in practice since App.WaitForElement("Action") already synchronizes with the swipe animation. The retryDelay/retryTimeout distinction only matters if the screenshot still captures an in-progress state after WaitForElement returns.

---

✅ Looks Good

• Core fix is correct. Checking item.Source is IFontImageSource with a non-null Color is the right way to detect an explicit color on FontImageSource. The fallback to GetTextColor() preserves existing behavior for non-FontImageSource cases.

• Rendering mode is correctly retained as AlwaysTemplate. This is required for tinting to work. A previous approach (apparently considered but not implemented) would have used AlwaysOriginal or Automatic, which would require the color to be baked into the image pixels instead — less clean.

• Backward compatibility is preserved. The change is strictly additive: existing code paths (no FontImageSource, or FontImageSource without an explicit color) take the existing GetTextColor() fallback.

• Android snapshot added. The test runs on both #if ANDROID || IOS and includes an Android snapshot. Since Android already honored the color (as noted in the issue), this adds useful cross-platform regression coverage.

• Error handling preserved. The new color logic is correctly inside the existing try/catch block.

• Null safety is correct. fontImageSource.Color != null is the appropriate check since Color is nullable on IFontImageSource.

---