Remove OpenMP dependency - #300
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## mainline #300 +/- ##
==============================================
+ Coverage 84.98% 85.18% +0.20%
Complexity 46 46
==============================================
Files 106 108 +2
Lines 8040 8156 +116
Branches 461 50 -411
==============================================
+ Hits 6833 6948 +115
- Misses 1182 1183 +1
Partials 25 25
Continue to review full report at Codecov.
|
trivialfis
reviewed
Jul 16, 2021
This was referenced Jul 16, 2021
Merged
rapids-bot Bot
pushed a commit
to NVIDIA/cuml
that referenced
this pull request
Jul 21, 2021
Closes #4037. The 2.0.0 version of Treelite incorporates the following major improvements: * **Remove dmlc-core dependency** (dmlc/treelite#284). * Rename CHECK and LOG macros to avoid name collisions (dmlc/treelite#295) * Suppress warning about build time when parallel_comp is specified (dmlc/treelite#297) * Handle LightGBM models with '=' in feature names (dmlc/treelite#298) * Remove OpenMP dependency (dmlc/treelite#300) Depends on rapidsai/integration#315 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) - Jordan Jacobelli (https://github.com/Ethyling) URL: #4072
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Closes NVIDIA#4037. The 2.0.0 version of Treelite incorporates the following major improvements: * **Remove dmlc-core dependency** (dmlc/treelite#284). * Rename CHECK and LOG macros to avoid name collisions (dmlc/treelite#295) * Suppress warning about build time when parallel_comp is specified (dmlc/treelite#297) * Handle LightGBM models with '=' in feature names (dmlc/treelite#298) * Remove OpenMP dependency (dmlc/treelite#300) Depends on rapidsai/integration#315 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) - Jordan Jacobelli (https://github.com/Ethyling) URL: NVIDIA#4072
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #299.
On MacOS, the latest OpenMP runtime (
libomp) is causing Treelite to hang. Fortunately, it is relatively painless to remove the use of OpenMP from Treelite, as only one feature of Treelite (branch annotator) uses it. (The Treelite runtime uses a custom thread pool.)Replace OpenMP with C++11 threads.
As a side effect, this PR also speeds up testing on MacOS, because we no longer have to install packages from Homebrew. This shaves off 15 min of CI time.