Skip to content

Upgrade Treelite to 2.0.0 - #4072

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:branch-21.08from
chyunsu3:branch-21.08
Jul 21, 2021
Merged

Upgrade Treelite to 2.0.0#4072
rapids-bot[bot] merged 3 commits into
NVIDIA:branch-21.08from
chyunsu3:branch-21.08

Conversation

@chyunsu3

@chyunsu3 chyunsu3 commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Closes #4037.

The 2.0.0 version of Treelite incorporates the following major improvements:

Depends on rapidsai/integration#315

@chyunsu3
chyunsu3 requested review from a team as code owners July 20, 2021 03:26
@github-actions github-actions Bot added CMake conda conda issue CUDA/C++ gpuCI gpuCI issue labels Jul 20, 2021
@chyunsu3 chyunsu3 added breaking Breaking change Tech Debt Issues related to debt improvement Improvement / enhancement to an existing function labels Jul 20, 2021
@chyunsu3 chyunsu3 added the 5 - Merge After Dependencies Depends on another PR: do not merge out of order label Jul 20, 2021
Comment thread ci/gpu/build.sh Outdated

@robertmaynard robertmaynard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CMake changes look good 👍

@dantegd dantegd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ change looks good

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@3c11ebd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4072   +/-   ##
===============================================
  Coverage                ?   85.60%           
===============================================
  Files                   ?      230           
  Lines                   ?    18221           
  Branches                ?        0           
===============================================
  Hits                    ?    15598           
  Misses                  ?     2623           
  Partials                ?        0           
Flag Coverage Δ
dask 48.14% <0.00%> (?)
non-dask 78.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c11ebd...a86d1e1. Read the comment docs.

@dantegd

dantegd commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

@gpucibot merge

@chyunsu3 chyunsu3 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - Merge After Dependencies Depends on another PR: do not merge out of order labels Jul 20, 2021
@dantegd
dantegd requested a review from ajschmidt8 July 21, 2021 00:10
@rapids-bot
rapids-bot Bot merged commit 11088d6 into NVIDIA:branch-21.08 Jul 21, 2021
@chyunsu3
chyunsu3 deleted the branch-21.08 branch July 21, 2021 09:11
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Closes NVIDIA#4037.

The 2.0.0 version of Treelite incorporates the following major improvements:

* **Remove dmlc-core dependency** (dmlc/treelite#284).
* Rename CHECK and LOG macros to avoid name collisions (dmlc/treelite#295)
* Suppress warning about build time when parallel_comp is specified (dmlc/treelite#297)
* Handle LightGBM models with '=' in feature names (dmlc/treelite#298)
* Remove OpenMP dependency (dmlc/treelite#300)

Depends on rapidsai/integration#315

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: NVIDIA#4072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change CMake conda conda issue CUDA/C++ improvement Improvement / enhancement to an existing function Tech Debt Issues related to debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Update Treelite to 2.0.0 to remove the dmlc-core dependency

7 participants