Handle LightGBM models with '=' in feature names - #298
Merged
Conversation
chyunsu3
commented
Jul 13, 2021
Collaborator
Author
There was a problem hiding this comment.
This test case creates a Pandas dataframe with '=' in the column names.
Codecov Report
@@ Coverage Diff @@
## mainline #298 +/- ##
==============================================
- Coverage 84.97% 84.75% -0.23%
Complexity 46 46
==============================================
Files 106 104 -2
Lines 8034 7019 -1015
Branches 50 50
==============================================
- Hits 6827 5949 -878
+ Misses 1182 1045 -137
Partials 25 25
Continue to review full report at Codecov.
|
chyunsu3
force-pushed
the
handle_feat_name_with_eq_sign
branch
from
July 13, 2021 23:43
0fe9cad to
80dd7a7
Compare
chyunsu3
commented
Jul 14, 2021
Comment on lines
+246
to
+249
| if (!rest.empty()) { | ||
| value += "="; | ||
| value += rest; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This change lets us handle the line
feature_names=x0=0 x0=1 x1=0 x1=1 x1=2
in model.txt.
Collaborator
Author
|
@trivialfis Can you take a quick look and see if the test case looks reasonable? |
trivialfis
reviewed
Jul 14, 2021
trivialfis
left a comment
trivialfis
left a comment
Member
There was a problem hiding this comment.
The test looks good. Maybe we can add a check to see if the generated model does have such feature names to be sure that we are testing the right thing.
This was referenced Jul 16, 2021
Merged
rapids-bot Bot
pushed a commit
to NVIDIA/cuml
that referenced
this pull request
Jul 21, 2021
Closes #4037. The 2.0.0 version of Treelite incorporates the following major improvements: * **Remove dmlc-core dependency** (dmlc/treelite#284). * Rename CHECK and LOG macros to avoid name collisions (dmlc/treelite#295) * Suppress warning about build time when parallel_comp is specified (dmlc/treelite#297) * Handle LightGBM models with '=' in feature names (dmlc/treelite#298) * Remove OpenMP dependency (dmlc/treelite#300) Depends on rapidsai/integration#315 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) - Jordan Jacobelli (https://github.com/Ethyling) URL: #4072
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Closes NVIDIA#4037. The 2.0.0 version of Treelite incorporates the following major improvements: * **Remove dmlc-core dependency** (dmlc/treelite#284). * Rename CHECK and LOG macros to avoid name collisions (dmlc/treelite#295) * Suppress warning about build time when parallel_comp is specified (dmlc/treelite#297) * Handle LightGBM models with '=' in feature names (dmlc/treelite#298) * Remove OpenMP dependency (dmlc/treelite#300) Depends on rapidsai/integration#315 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) - Jordan Jacobelli (https://github.com/Ethyling) URL: NVIDIA#4072
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #281