Skip to content

Suppress warning about build time when parallel_comp is specified - #297

Merged
chyunsu3 merged 2 commits into
dmlc:mainlinefrom
chyunsu3:suppress_warning_build_time
Jul 14, 2021
Merged

Suppress warning about build time when parallel_comp is specified#297
chyunsu3 merged 2 commits into
dmlc:mainlinefrom
chyunsu3:suppress_warning_build_time

Conversation

@chyunsu3

Copy link
Copy Markdown
Collaborator

Closes #279

@codecov

codecov Bot commented Jul 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #297 (169bf6d) into mainline (d037bb4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             mainline     #297   +/-   ##
===========================================
  Coverage       84.97%   84.98%           
  Complexity         46       46           
===========================================
  Files             106      106           
  Lines            8034     8037    +3     
  Branches           50       50           
===========================================
+ Hits             6827     6830    +3     
  Misses           1182     1182           
  Partials           25       25           
Impacted Files Coverage Δ
python/treelite/contrib/__init__.py 75.40% <100.00%> (+0.20%) ⬆️
python/treelite/frontend.py 77.35% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d037bb4...169bf6d. Read the comment docs.

@chyunsu3
chyunsu3 merged commit 6b64481 into dmlc:mainline Jul 14, 2021
@chyunsu3
chyunsu3 deleted the suppress_warning_build_time branch July 14, 2021 00:54
This was referenced Jul 16, 2021
rapids-bot Bot pushed a commit to NVIDIA/cuml that referenced this pull request Jul 21, 2021
Closes #4037.

The 2.0.0 version of Treelite incorporates the following major improvements:

* **Remove dmlc-core dependency** (dmlc/treelite#284).
* Rename CHECK and LOG macros to avoid name collisions (dmlc/treelite#295)
* Suppress warning about build time when parallel_comp is specified (dmlc/treelite#297)
* Handle LightGBM models with '=' in feature names (dmlc/treelite#298)
* Remove OpenMP dependency (dmlc/treelite#300)

Depends on rapidsai/integration#315

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: #4072
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Closes NVIDIA#4037.

The 2.0.0 version of Treelite incorporates the following major improvements:

* **Remove dmlc-core dependency** (dmlc/treelite#284).
* Rename CHECK and LOG macros to avoid name collisions (dmlc/treelite#295)
* Suppress warning about build time when parallel_comp is specified (dmlc/treelite#297)
* Handle LightGBM models with '=' in feature names (dmlc/treelite#298)
* Remove OpenMP dependency (dmlc/treelite#300)

Depends on rapidsai/integration#315

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: NVIDIA#4072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minor console output improvement

1 participant