Skip to content

[Breaking] Remove dmlc-core dependency - #285

Merged
chyunsu3 merged 18 commits into
dmlc:mainlinefrom
chyunsu3:remove_dmlc
Jul 12, 2021
Merged

[Breaking] Remove dmlc-core dependency#285
chyunsu3 merged 18 commits into
dmlc:mainlinefrom
chyunsu3:remove_dmlc

Conversation

@chyunsu3

@chyunsu3 chyunsu3 commented Jul 8, 2021

Copy link
Copy Markdown
Collaborator

Closes #244

This PR will be divided into smaller PRs for easier review.

Marking this PR as "breaking," per discussion in #284

@chyunsu3 chyunsu3 changed the title Remove dmlc-core dependency [Breaking] Remove dmlc-core dependency Jul 8, 2021
@codecov

codecov Bot commented Jul 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #285 (bf3e612) into mainline (4dd95c4) will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #285      +/-   ##
==============================================
+ Coverage       85.10%   85.11%   +0.01%     
  Complexity         46       46              
==============================================
  Files             106      106              
  Lines            8014     8020       +6     
  Branches           50       50              
==============================================
+ Hits             6820     6826       +6     
  Misses           1169     1169              
  Partials           25       25              
Impacted Files Coverage Δ
runtime/java/treelite4j/src/native/treelite4j.cpp 66.85% <ø> (ø)
src/annotator.cc 91.47% <ø> (ø)
src/c_api/c_api.cc 97.09% <ø> (ø)
src/compiler/ast/build.cc 98.14% <ø> (+1.78%) ⬆️
src/compiler/ast/dump.cc 0.00% <ø> (ø)
src/compiler/ast/fold_code.cc 88.46% <ø> (+1.66%) ⬆️
src/compiler/ast/is_categorical_array.cc 100.00% <ø> (+7.14%) ⬆️
src/compiler/ast/load_data_counts.cc 100.00% <ø> (+9.09%) ⬆️
src/compiler/ast/quantize.cc 100.00% <ø> (+1.88%) ⬆️
src/compiler/ast/split.cc 100.00% <ø> (+2.27%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd95c4...bf3e612. Read the comment docs.

@chyunsu3

chyunsu3 commented Jul 8, 2021

Copy link
Copy Markdown
Collaborator Author

Removed irrelevant changes, to make this PR smaller.

@chyunsu3
chyunsu3 force-pushed the remove_dmlc branch 4 times, most recently from 233523a to f9effa8 Compare July 8, 2021 23:52
@chyunsu3

chyunsu3 commented Jul 9, 2021

Copy link
Copy Markdown
Collaborator Author

I've split this PR into smaller chunks: #287, #288, #289, #290, #291, #292, #293.

@chyunsu3
chyunsu3 merged commit 5c5aa9f into dmlc:mainline Jul 12, 2021
@chyunsu3
chyunsu3 deleted the remove_dmlc branch July 12, 2021 07:48
@chyunsu3 chyunsu3 mentioned this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dmlc-core dependency

2 participants