[Breaking] Remove dmlc-core dependency - #285
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## mainline #285 +/- ##
==============================================
+ Coverage 85.10% 85.11% +0.01%
Complexity 46 46
==============================================
Files 106 106
Lines 8014 8020 +6
Branches 50 50
==============================================
+ Hits 6820 6826 +6
Misses 1169 1169
Partials 25 25
Continue to review full report at Codecov.
|
Collaborator
Author
|
Removed irrelevant changes, to make this PR smaller. |
chyunsu3
force-pushed
the
remove_dmlc
branch
4 times, most recently
from
July 8, 2021 23:52
233523a to
f9effa8
Compare
This commit REMOVES the ability for DMatrix to load data from text files.
This was referenced Jul 9, 2021
Merged
chyunsu3
marked this pull request as ready for review
July 9, 2021 05:21
This was referenced Jul 9, 2021
trivialfis
approved these changes
Jul 12, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #244
This PR will be divided into smaller PRs for easier review.
Marking this PR as "breaking," per discussion in #284