[Breaking] Remove dmlc::Parameter - #293
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## mainline #293 +/- ##
==============================================
- Coverage 84.78% 83.99% -0.79%
Complexity 46 46
==============================================
Files 101 102 +1
Lines 7899 7909 +10
Branches 50 50
==============================================
- Hits 6697 6643 -54
- Misses 1177 1241 +64
Partials 25 25
Continue to review full report at Codecov.
|
This was referenced Jul 9, 2021
trivialfis
reviewed
Jul 11, 2021
| _check_call(_LIB.TreeliteCompilerGenerateCode( | ||
| if verbose and _params: | ||
| _params['verbose'] = 1 | ||
| params_json_str = json.dumps(_params) if _params else '{}' |
Member
There was a problem hiding this comment.
I think JSON handles this automatically.
Collaborator
Author
There was a problem hiding this comment.
No, the None object gets serialized to null.
Member
There was a problem hiding this comment.
Got it, the param is optional.
trivialfis
approved these changes
Jul 11, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #285.
dmlc/parameter.h.CompilerParamno longer inherits fromdmlc::Parameter. Consequently, it now implements a special methodParseFromJSON()that ingests parameters from a JSON string.Before:
After:
TreeliteCompilerCreateandTreeliteCompilerGenerateCodeare renamed toTreeliteCompilerCreateV2andTreeliteCompilerGenerateCodeV2, respectively, to indicate the different calling signature. In addition,TreeliteCompilerSetParamhas been removed.ParseFromJSON().