Remove dmlc::Timer and dmlc::optional - #292
Merged
Merged
Conversation
chyunsu3
commented
Jul 9, 2021
Comment on lines
+20
to
+24
| #if defined(__APPLE__) && defined(__MACH__) | ||
| #include <mach/mach.h> | ||
| #include <mach/mach_init.h> | ||
| #include <mach/thread_policy.h> | ||
| #endif |
Collaborator
Author
There was a problem hiding this comment.
This is needed to avoid build failure on MacOS.
Codecov Report
@@ Coverage Diff @@
## mainline #292 +/- ##
==============================================
+ Coverage 84.99% 85.01% +0.01%
Complexity 46 46
==============================================
Files 103 104 +1
Lines 7959 7979 +20
Branches 50 50
==============================================
+ Hits 6765 6783 +18
- Misses 1169 1171 +2
Partials 25 25
Continue to review full report at Codecov.
|
This was referenced Jul 9, 2021
trivialfis
approved these changes
Jul 11, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #285.
dmlc/optional.handdmlc/timer.h.GetTime()andoptional<>.