Remove dmlc logger - #287
Merged
Merged
Conversation
chyunsu3
force-pushed
the
remove_dmlc_logger
branch
from
July 9, 2021 01:41
6164c13 to
c883026
Compare
Codecov Report
@@ Coverage Diff @@
## mainline #287 +/- ##
==============================================
+ Coverage 85.03% 85.10% +0.06%
Complexity 46 46
==============================================
Files 106 106
Lines 7978 8014 +36
Branches 50 50
==============================================
+ Hits 6784 6820 +36
Misses 1169 1169
Partials 25 25
Continue to review full report at Codecov.
|
This was referenced Jul 9, 2021
trivialfis
reviewed
Jul 11, 2021
chyunsu3
force-pushed
the
remove_dmlc_logger
branch
from
July 11, 2021 12:08
cd38b74 to
d0b3482
Compare
chyunsu3
force-pushed
the
remove_dmlc_logger
branch
from
July 11, 2021 12:15
d0b3482 to
cec5737
Compare
trivialfis
reviewed
Jul 11, 2021
trivialfis
approved these changes
Jul 12, 2021
Collaborator
Author
|
@trivialfis Thank you so much for reviewing the 7 pull requests! I was worried about the size of the changes required to remove |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #285. Re-implement logging functionalities such as
CHECKandLOG, so that we no longer depend on the headerdmlc/logging.h.