Repository navigation
fix(proxy): preserve required egress for no-auth account proxy references - #15087
diegosouzapw merged 6 commits into
Conversation
|
CI documentation-gate attribution on the current head and exact
This is the new-cycle base's documentation drift, not a candidate-owned regression. I have not edited instruction surfaces or loosened the gate to make this branch green. Other CI jobs are tracked separately; this is not a full CI-green claim. |
|
Thanks for picking this up so quickly — the fix matches the issue on all three points: account references counted in the 409 path (with connection/provider/count diagnostics, no secrets), I ran the comparison myself so you don't have to take my word for it: normalized One real regression from this PR, in Thanks again for the request-path probe with zero-fetch 503 — that's exactly the evidence this needed. |
…ount-reference wording The guard now says 'Remove assignments or account references first'; the v1 proxies route test still matched the old 'remove assignments first' phrase. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
#15103) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…ped calls (#15178) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…e bundles (#15255) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
#15240) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…ll is in flight (#15261) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
… catalog (#15219) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…15206) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…15209) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…15107) (#15252) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…4850) (#15254) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…15262) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…edirect (#15280) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…ops re-reading (#15117) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…ex turn (#15168) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…m relayed output (#15186) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…15140) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…5155) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
…thesized outputs (#15216) (#15231) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
… combos (#15086) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
3345aba
into
diegosouzapw:release/v3.8.52
… can't time out (#15106) (#15253) Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
Validated in a local merge-train on tomni-proxmox-113 (static gates + changed tests + vitest green on the 31-PR combined tree; the FULL unit run on the same set showed only load-timing flakes, the base-red consoleInterceptor-writes, and one regression since fixed in #15087).⚠️ base-red inherited: #15306
|
Thanks @xiaoyaner0201 — merged into |
Summary
Preserve required proxy intent for no-auth account references, including after a proxy is force-deleted. This closes the reported OpenCode by-id account-proxy path without changing deliberately unconfigured/inline proxy behavior.
Fixes #15007.
Behavior
accountProxies[].proxyIdreferences ingetProxyWhereUsed, counting references across accounts/connections alongside ordinary assignments.proxy_in_useresponse when account references remain. New diagnostics expose connection/provider/count only, not fingerprints, API keys, proxy credentials or raw provider metadata.force=1in the HTTP API) deletes the registry entry but retains the account's unresolved required binding. Clearing that reference would silently authorize direct traffic. An explicit account edit/reassignment/unbind is the separate way to change that intent.proxy_unavailablebefore any upstream fetch. Unconfigured accounts remain direct and mixed lists retain healthy members.No new policy framework, migration, dependency, automatic reassignment or connection deletion/disable.
Verification
Base: active
release/v3.8.52at666ea59b4c5980062c4012ee9228135ee4dd8989.7993-noauth-proxy-routing.test.ts,opencode-accounts-per-request.test.ts).getProviderCredentialshydration and real OpenCode executor with a mocked upstream: default delete 409; forced delete 200; next request 503 with zero fetches; explicit unbind then returns 200 with one fetch. No live provider credentials/request used.Existing base failures and limits
typecheck:noimplicit:core: identicalautoStrategy.ts:519 TS7006on candidate and exact base.Tests
tests/unit/noauth-proxy-resolution.test.tstests/unit/proxy-account-references-15007.test.tstests/unit/opencode-required-proxy-15007.test.ts