Repository navigation
fix(combo): keep the caller's connection pin through the safety-net redirect - #15280
Merged
diegosouzapw merged 1 commit intoOct 2, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
…edirect handleSingleModelChat forwards a named combo into handleComboChat. The options it rebuilt hardcoded forcedConnectionId to null, so a pin from x-omniroute-connection never reached account selection and a quota-weighted pool served one connection for every pin. Forward the caller's pin. The emergency fallback still clears it. The guard bounds each block with a marker that appears once, then reads every forcedConnectionId assignment inside it. Signed-off-by: Minxi Hou <houminxi@gmail.com>
HouMinXi
force-pushed
the
fix/combo-forced-connection
branch
from
October 1, 2026 14:01
fc10898 to
d5ee814
Compare
diegosouzapw
merged commit Oct 2, 2026
ba8e944
into
diegosouzapw:release/v3.8.52
15 of 16 checks passed
Owner
|
Thanks @HouMinXi — merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
handleSingleModelChatforwards a request whose model names a combo intohandleComboChat. The options object it rebuilt for that call hardcodedforcedConnectionId: null.A caller that sends
x-omniroute-connection: <id>therefore lost the pin as soon as the model resolved to a combo. Account selection fell through to the pool strategy. On a quota-weighted pool every pinned request landed on the single highest-quota connection.The redirect now forwards
runtimeOptions.forcedConnectionId. The emergency fallback path still clears the pin, and a test locks that split.How to verify
node --test tests/unit/chat-safetynet-pin.test.tsReverting the one changed line in
src/sse/handlers/chat.tsturns the redirect assertion red. Restoring it turns it green. The emergency-fallback assertion stays green either way.