Repository navigation
fix(sse): retry advisor 400 with unreadable results marked unavailable - #15103
Merged
diegosouzapw merged 3 commits intoOct 2, 2026
Conversation
diegosouzapw
changed the base branch from
release/v3.8.51
to
release/v3.8.52
September 29, 2026 15:28
…f executors/base.ts to stay under the frozen size Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
merged commit Oct 2, 2026
24ebb1f
into
diegosouzapw:release/v3.8.52
47 of 51 checks passed
Owner
|
Thanks @cryptiklemur — merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
advisor_redacted_resultfor the org that made it. when a Claude conversation moves to another account, the new account cant read those results. the request fails with a 400: "Advisor tool result content could not be processed."BaseExecutornow retries once on the same connection. eachadvisor_tool_resultholding anadvisor_redacted_resultgets its content swapped for{ type: "advisor_tool_result_error", error_code: "unavailable" }. the pairedserver_tool_useand every other block stay as they are.execute()call, so they dont re-hit the same 400.open-sse/config/providerFieldStrips.ts:isAdvisorUndecryptableError()andreplaceRedactedAdvisorResults().open-sse/executors/base.tsthat are unused on this branch, and voids the unusedhealthparam. that clears the 5no-unused-varssuppressions for the file, so its entry is pruned fromconfig/quality/eslint-suppressions.json.Related Issues
Validation
npm run lint: no errors. it exits 2 only becauserelease/v3.8.51has 5 stale suppressions in unrelated files (openai-to-cursor.ts,SystemStorageTab.tsx, both vscodecombos/route.ts,ghe-copilot.ts). the same happens on the base, and--pass-on-unpruned-suppressionsexits 0.base.tschangebase-executor-*,executor-base-utils,field-400-downgrade,param-filters-auto-learn,provider-field-strips,reasoning-effort-clamp-and-retry,context-editing-executor-injectionTests Added Or Updated
tests/unit/base-advisor-undecryptable-retry.test.ts(new)Coverage Notes
Reviewer Notes
error.messagestring. a reworded Anthropic message will skip the retry and fail the way it does today.unavailableadvisor error instead of a hard failure.