Repository navigation
fix(capabilities): honor model-compat vision overrides in catalog and combos - #15086
diegosouzapw merged 2 commits into
Conversation
|
CI documentation-gate attribution on the current head and exact
This is the new-cycle base's documentation drift, not a candidate-owned regression. I have not edited instruction surfaces or loosened the gate to make this branch green. Other CI jobs are tracked separately; this is not a full CI-green claim. |
b901cff
into
diegosouzapw:release/v3.8.52
|
Thanks @xiaoyaner0201 — merged into |
Summary
Make the canonical vision-capability resolver consume the existing per-model compatibility override that runtime routing already honors. This is the override-wiring slice of #14587; per-member combo diagnostics remain out of scope and the issue should stay open for them.
Refs #14587. Builds on, but does not replace, #14642.
Behavior
falsestays authoritative.Relationship to our earlier #14642
#14642 fixed own-provider prefix normalization for the already-supported Custom Models source. It did not introduce the compat-source omission.
We compared the exact
modelCapabilities.tsfrom #14642's parentcbb2ebef0de2473f888c61950c91b9714e93ece7and its mergee7738bda3ccef180a0814a64da68d9c6727f3cd2, using a shared dependency environment and fresh temporary SQLite fixtures. The parent source was reconstructed from the exact patch and its Git blob matched the real parent tree entry.truebefore and after.nullbefore,trueafter.nullbefore and after, while runtimegetModelInforeads the same compat override astrue.This is a source-isolated A/B, not a replay of an entire historical deployment. It establishes the omitted read source predates #14642. That prefix fix now also helps the new compat lookup resolve prefixed combo inputs.
Verification
Candidate tested against
release/v3.8.52at666ea59b4c5980062c4012ee9228135ee4dd8989.null !== trueassertion.npm run build:contributorpasses (backend/API compilation, not a full release/package build).Existing base failures / scope limits
typecheck:noimplicit:core: the sameautoStrategy.ts:519 TS7006on candidate and exact base.Tests added
tests/unit/model-compat-vision-canonical-resolution-14587.test.tsConcurrent PRs
Trial-merge against #15087 succeeds, including the independent Stryker registrations. The only shared path with the existing Team/cost-center PR #10409 is
config/quality/eslint-suppressions.json. Its old public head already conflicts with the current base; the trial merge with this PR reports exactly the same conflict-path set as the base-only control. #10409 should reconcile that suppression file when refreshing onto the current cycle; this PR does not depend on it.