Skip to content

chore(quality): rebaseline file-size caps the error-boundary campaign grew past - #12654

Merged
diegosouzapw merged 1 commit into
release/v3.8.51from
fix/release-v3.8.51-filesize-boundaries
Sep 4, 2026
Merged

diegosouzapw merged 1 commit into
release/v3.8.51from
fix/release-v3.8.51-filesize-boundaries

Conversation

@diegosouzapw

Copy link
Copy Markdown
Owner

Third of the day's rebaselines (after #12619 and #12623), for the error-boundary campaign (#12431 #12438 #12444 #12454 #12455 #12456 #12457 #12458 #12459 #12465 #12466 #12467 #12469 #12435).

Measured on the release tip with all fourteen merged:

open-sse/executors/codex.ts                  1499 -> 1505
open-sse/vendor/codex-chatgpt-web/bridge.ts  1322 -> 1335

An honest split, written into the annotation rather than hidden: of codex.ts's six lines, four (1499→1503) were already drift on the tip before this campaign — they show up in the same measurement I have been reporting all day — and only the last two came from #12444, which closes the Codex response-failure boundary. The cap is a single number, so absorbing the pre-existing drift along with the batch's own growth is unavoidable; what is avoidable is letting that go unrecorded, so the decomposition is in the baseline entry.

bridge.ts (+13) is entirely #12444, on the same failure path.

Deliberately not included: open-sse/utils/stream.ts (3078 > 3072), a separate pre-existing drift that no PR in this campaign touches. After this PR it is the only remaining check-file-size violation.

… grew past

Measured on the release tip with all fourteen merged:

  open-sse/executors/codex.ts               1499 -> 1505
  open-sse/vendor/codex-chatgpt-web/bridge.ts 1322 -> 1335  (#12444)

Recorded honestly in the annotation: of codex.ts's six lines, four (1499->1503)
were already drift on the tip before this campaign and only two came from
#12444. The cap is a single number, so absorbing the pre-existing drift is
unavoidable — the split is written down instead of hidden.

Does not touch open-sse/utils/stream.ts, whose violation is separate,
pre-existing drift.
@diegosouzapw
diegosouzapw merged commit 5ba4247 into release/v3.8.51 Sep 4, 2026
8 of 11 checks passed
@diegosouzapw
diegosouzapw deleted the fix/release-v3.8.51-filesize-boundaries branch September 4, 2026 00:19
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
… grew past (diegosouzapw#12654)

Rebaseline medido no tip com os 14 PRs da campanha mergeados. A anotação registra que 4 das 6 linhas do codex.ts são drift anterior à campanha, não crescimento dela. Não toca stream.ts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant