Repository navigation
fix(sse): surface Adapta non-stream SSE errors - #12459
Merged
diegosouzapw merged 4 commits intoSep 3, 2026
Merged
Conversation
…adapta-nonstream-error-boundary
…adapta-nonstream-error-boundary
diegosouzapw
marked this pull request as ready for review
September 3, 2026 23:57
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
Validado em lote numa worktree combinada com os 14 PRs desta campanha de error-boundary sobre o tip de `release/v3.8.51`: `typecheck:core` limpo e **120/120** nos 23 arquivos de teste que os PRs trazem. Um ponto que só apareceu no tree combinado: **diegosouzapw#12465 e diegosouzapw#12466 criam o mesmo arquivo novo** `open-sse/utils/streamReadiness.ts` (que não existe no tip) com desenhos divergentes de cancelamento — `cancelled` + `releaseLock` imediato num, `readInFlight`/`cancelRequested` com `cancelReader` fire-and-forget no outro. Adotei a versão do diegosouzapw#12466, que difere e defere o release do lock para quando a leitura em voo termina, e validei a escolha rodando as suítes dos **dois** PRs contra ela: 21/21 no readiness compartilhado e 22/22 incluindo o boundary do Perplexity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type:errorevents inside successful HTTP 200 SSE responses when the caller requestedstream: false.buildErrorBody, so upstream diagnostics, paths, credentials, and stack material do not cross the response boundary.DATA_DIR, plugin directory, fetch hook, or DB singleton.Behavior
type:errorserver_error/bad_gatewayerrorTextAdapta upstream errortext-deltasequenceDATA_DIRand reset the shared DBValidation
Candidate SHA:
23434779ef41db82dd68f735974cf89ac4164a0dCandidate tree:
79234912cfe96841d7af21fe25ac2934436fa815200 !== 502) → GREENomniroute-adapta-nonstream-error-*, proving silent cross-test state capture. A deterministic call-log-first import probe failed 3/4 at the artifact assertion (false !== true) after Adapta replacedDATA_DIRcall-log-save-drain + Adapta wrapperunder--test-isolation=none: 3/3; DB remained underomniroute-call-log-drain-*env -ichild; all 13 original assertions preserved...process.env, noHOME, no ambient provider/session credentials; explicit runtime allowlist, syntheticAPI_KEY_SECRET, child-local temporary data/plugin directories, inheritedNODE_TEST_CONTEXTremoved0openSseTypecheckErrors=0git diff --checkcleane243b04de22da2d78900c27fde5f83f4fbc3d7f9; no owned-path overlap; merge commit23434779ef41db82dd68f735974cf89ac4164a0d23434779ef41db82dd68f735974cf89ac4164a0dNo live provider request or real credential was used.
Scope
changelog.d/fixes/adapta-nonstream-sse-error.mdopen-sse/executors/adapta-web.tstests/fixtures/adapta-web-nonstream-error-boundary.fixture.tstests/unit/adapta-web-nonstream-error-boundary.test.ts