Skip to content

chore(quality): rebaseline file-size caps the HouMinXi batch grew past when stacked - #12619

Merged
diegosouzapw merged 1 commit into
release/v3.8.51from
fix/release-v3.8.51-filesize-houminxi
Sep 3, 2026
Merged

diegosouzapw merged 1 commit into
release/v3.8.51from
fix/release-v3.8.51-filesize-houminxi

Conversation

@diegosouzapw

Copy link
Copy Markdown
Owner

The nine PRs of the HouMinXi batch (#12312 #12495 #12325 #12504 #12487 #12488 #12566 #12557 #12590) each measured their own file-size growth correctly against the tip they forked from. Three files were touched by more than one of them, so the caps only broke once they were stacked — which is why every PR was green on its own and the release tip went red after they all landed.

Measured on the release tip with all nine merged:

src/app/(dashboard)/dashboard/providers/page.tsx  2007 -> 2025  (+18)
open-sse/handlers/chatCore.ts                     5981 -> 5984  (+3)
open-sse/services/accountFallback.ts              2461 -> 2467  (+6)

All three are wiring at existing chokepoints, not extractable without splitting the functions mid-response-flow.

Deliberately not included: open-sse/executors/codex.ts (1503 > 1499) and open-sse/utils/stream.ts (3078 > 3072). Both were already over their caps on the pure tip before this batch — that is base drift and belongs to its own base-red sweep, not here.

After this PR the only remaining check-file-size violations are those two.

The nine PRs of that batch each measured their own growth correctly against
the tip they forked from, but three files were touched by more than one of
them, so the caps only broke once they were stacked:

  providers/page.tsx     2007 -> 2025  (#12504 CSV import errors + #12495 search)
  chatCore.ts            5981 -> 5984  (#12325 generic quota cache drop on 429)
  accountFallback.ts     2461 -> 2467  (#12566 on top of #12590's own rebaseline)

Measured on the release tip with all nine merged. Does not touch codex.ts or
stream.ts, which were already over their caps before this batch.
@diegosouzapw
diegosouzapw merged commit d9526ce into release/v3.8.51 Sep 3, 2026
8 of 11 checks passed
@diegosouzapw
diegosouzapw deleted the fix/release-v3.8.51-filesize-houminxi branch September 5, 2026 05:11
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
diegosouzapw#12619)

Rebaseline medido no tip com os 9 PRs da leva mergeados. Desfaz o vermelho de file-size que os PRs empilhados deixaram; não toca codex.ts nem stream.ts, que já violavam antes da leva.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant