fix(providers): separate MaxAI and UC credential contracts - #12431
Merged
diegosouzapw merged 3 commits intoSep 3, 2026
Merged
Conversation
…1-web-session-credentials-syntax
…web-session-credentials-syntax
diegosouzapw
marked this pull request as ready for review
September 3, 2026 23:56
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…apw#12431) Validado em lote numa worktree combinada com os 14 PRs desta campanha de error-boundary sobre o tip de `release/v3.8.51`: `typecheck:core` limpo e **120/120** nos 23 arquivos de teste que os PRs trazem. Um ponto que só apareceu no tree combinado: **diegosouzapw#12465 e diegosouzapw#12466 criam o mesmo arquivo novo** `open-sse/utils/streamReadiness.ts` (que não existe no tip) com desenhos divergentes de cancelamento — `cancelled` + `releaseLock` imediato num, `readInFlight`/`cancelRequested` com `cancelReader` fire-and-forget no outro. Adotei a versão do diegosouzapw#12466, que difere e defere o release do lock para quando a leitura em voo termina, e validei a escolha rodando as suítes dos **dois** PRs contra ela: 21/21 no readiness compartilhado e 22/22 incluindo o boundary do Perplexity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
OWN SCOPE: PASS · RECONCILED · CI: PASS
The branch is reconciled with the current
release/v3.8.51tip. The production repair is already present on the live base; this PR now contributes only the regression test that keeps the MaxAI and UC credential contracts independent.Summary
The malformed MaxAI credential entry originally left
maxai.storageKeysopen before theucproperty. TypeScript then parsed UC inside the preceding array/object and emitted 11 syntax diagnostics.The release branch now contains the production repair. This PR preserves the missing regression guard: MaxAI and UC must remain separate top-level entries with independent storage keys and credential metadata.
Final candidate delta
bf0d902dfc5369bd025f64808d96fe6cb473ea75c422dd4fced77fe3869491bddfeb6fc00119cce9tests/unit/web-session-credentials.test.tsonly,+27linessrc/shared/providers/webSessionCredentials.tsblob (20548eda56f2c333e11775dd4a8638d257a1e81a)Validation
5/5,0failures306/306,0failures on the reconciled candidatenpm run typecheck:core289pre-existing diagnostics, all inside the frozen baseline;0newnpx eslint tests/unit/web-session-credentials.test.tsnpx prettier --check tests/unit/web-session-credentials.test.tsgit diff --check origin/release/v3.8.51..HEAD9successful,0failed,0pending;7skipped and2neutral are not reported as passesBase-red attribution
The release line has a separately verified BASE-RED for the official full-repository lint at exact base
6da2418247d75acd0af3a617c7289b004b5a86f5: orphaned entries inconfig/quality/eslint-suppressions.json. This PR neither edits production code nor changes the suppression inventory, and the owned test file passes ESLint. The fresh GitHub checks against the current base above are green.Draft only. No merge, automerge, deploy, or release action requested.