Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config/redirects from os to deriv app #17861

Conversation

shahzaib-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

github-actions bot and others added 30 commits November 25, 2024 13:11
* chore: remove translation from label

* chore: remove comment

* chore: add brackets

* chore: add key for icon
…l signup flow (deriv-com#17497)

* feat: added the console error tracking for the virtual signup flow

* fix: removed the console errors

* feat: added the console trackjs error for the user signup flow

* fix: peer comments

* fix: removed the localized error message

* fix: removed the localize form analytics

* fix: changed the naming of the feature f;ag variable

* fix: added a condition inside the country selection screen for capturing multiple errors

* fix: updated the ref with state of password model

* fix: added the console

* fix: added the feature condition inside trackconsole method

* fix: changed the default value to true

* fix: added the dependency for useeffect

* fix: peer comments

* fix: added the screen name for the signup button
* fix: testing user id

* chore: add cacheTrackEvents for missing user id

* fix: fix type

* fix: revert isReady change

* fix: failing test cases

* fix: empty commit

* fix: test
…7567)

* refactor: reset the stop loss value on trade type change

* feat: create error observer component for trade params error and a helper hook

* refactor: tak

* refactor: add tests for new component

* refactor: hook

* fix: independent tp and sl validation

* refactor: add tests

* chore: remove unused code

* fix: add date start field to the observes

* refactor: rename componnets and params
…deriv-com#17655)

* chore: update utils package to fix state regex issue

* chore: empty commit
…mpare account table for wallets (deriv-com#17516)

* fix(wallets): 🚑 remove the jurisdiction information

* refactor(wallets): 🔥 remove unused hardcoded values

* refactor(wallets): ♻️ refactor compare accounts table to use data from the API

* chore: exclude gold MT5 product from compare table
…#17311)

* chore: change from normal input field to dropdown with input field for confirm phone number screen

* chore: update phone number dropdown list and added a hook

* chore: add code dropdown in legacy settings page

* chore: hide sms based on carriers available

* chore: update functionality for phone number in personal details

* chore: fix test case and changes validation based on FF

* chore: make inputmode numeric

* chore: change display mobile number in phone otp verification page and verified modal

* chore: add validation for calling_country_code and fix logics for FF off

* chore: upgrade quill-ui package for Input Phone Number component

* chore: upgrade package to add more flags in country code drop down

* chore: fix changing language logs user out issue

* chore: add loading checks for confirm phone number screen

* chore: fix verified hint message

* chore: fix mobile modal for input phone number dropdown

* chore: hide verify and notification if carriers are empty

* chore: call phone_settings on first initialization

* chore: add condition for displaying sms and whatsapp button

* chore: update logic lo check global carriers

* chore: change select native to include boolean value

* chore: add check to hide or display verify button

* chore: fix test case fail for validation

* chore: update code based on comments

* chore: fix unable to submit profile settings

* chore: update quill-ui package and include search function

* chore: fix console log error and submitting phone number error

* chore: update code based on comments

* chore: update quill-ui package to fix bundle size issue

* chore: remove unused commented code

* chore: switch off autoComplete for browsers

* chore: add + sign at step 3 and verified modal

* chore: sort list based on alphabetical order

* chore: fix undefined error message and test case failing issue

* chore: update quill-ui package to have scroll to value selected

* chore: edit scss for rtl and update package for fix search bar

* chore: update package-lock.json

* chore: make rtl look better in phone and desktop

* chore: fix verify button disable and enable issue

* chore: fix GB console log issue

* chore: edit error message for country code

* chore: make country code dropdown to 40% width
…nglish (deriv-com#17637)

* fix: rudderstack action in english

* fix: change var name

* fix: action language fix
…eriv-com#17583)

* feat(appstore): ✨ add wallet migration flow for EU clients

* fix(appstore): 🚑 fix demo eu migration flow

* fix(wallets): 🚑 fix modal height in mobile view
… refreshing when changing market type (deriv-com#17644)

* fix: payout per point component

* fix: add barrier to the array with dependencies
thisyahlen-deriv and others added 3 commits December 17, 2024 11:10
* fix: account switching

* chore: empty commit

---------

Co-authored-by: Thisyahlen <[email protected]>
…account (deriv-com#17823)

* chore: fix misleading info when creating DXTrader account

* chore: update code based on comments
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 19, 2024 8:46am

Copy link
Contributor

@likhith-deriv likhith-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be files not related to this PR. Does this PR need changes to features in highcode and yml as well?

Copy link
Contributor

github-actions bot commented Dec 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 36
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-config-redirects-from-aea58d.binary.sx/

@shahzaib-deriv shahzaib-deriv merged commit 9708e4b into deriv-com:test_redirection_to_account_settings Dec 19, 2024
12 checks passed
@shahzaib-deriv
Copy link
Contributor Author

There seem to be files not related to this PR. Does this PR need changes to features in highcode and yml as well?

The changes are from master which are not in this branch, this is why we are seeing these changes in this PR

The changes are going to be deployed to UAT for redirection testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.