-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: trustpilot changes #17581
Open
utkarsha-deriv
wants to merge
1
commit into
deriv-com:master
Choose a base branch
from
utkarsha-deriv:utkarsha/trustpilot-notification-latest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: trustpilot changes #17581
utkarsha-deriv
wants to merge
1
commit into
deriv-com:master
from
utkarsha-deriv:utkarsha/trustpilot-notification-latest
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsha-deriv
requested review from
ali-hosseini-deriv,
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv,
sandeep-deriv,
wojciech-deriv and
yashim-deriv
as code owners
November 19, 2024 11:19
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
likhith-deriv
approved these changes
Nov 19, 2024
utkarsha-deriv
temporarily deployed
to
Preview
November 19, 2024 11:22
— with
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 11911950181Details
💛 - Coveralls |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-utkarsha-deriv-utkarsha-trustpilot-no-11c3da.binary.sx/ |
Dhruv-deriv
approved these changes
Nov 19, 2024
amina-deriv
approved these changes
Nov 19, 2024
suisin-deriv
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Display Trustpilot Review Notification based on
customer_review_eligible
status received inget_account_status
API. This PR removes the existing business logic for displaying trustpilot notification.Screenshots:
Please provide some screenshots of the change.