Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRWT-3232 / Kate / DTrader-V2] Market info price keeps on loading for other chart time interval #17641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kate-deriv
Copy link
Contributor

Changes:

  • Added missing data when granularity is !== 0

Screenshots:

Screen.Recording.2024-11-22.at.12.18.26.PM.mov

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 22, 2024 10:27am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11970463903

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 53.903%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/Stores/Modules/Trading/trade-store.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 11969509721: -0.006%
Covered Lines: 32677
Relevant Lines: 56593

💛 - Coveralls

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17641](https://github.com/deriv-com/deriv-app/pull/17641)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-grwt-3232marketpricefix.binary.sx?qa_server=red.derivws.com&app_id=30371
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-grwt-3232marketpricefix.binary.sx
- **App ID**: `30371`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-grwt-3232marketpricefix.binary.sx/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants