Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT]maryia/GRWT-2382/fix: Run panel animation result does not match contact result on win/loss #17627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maryia-matskevich-deriv
Copy link
Contributor

Changes:

fix: Run panel animation result does not match contact result on win/loss

!we need the value of each transaction of the profit field relative to one contract, not just the first one

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 21, 2024 1:27pm

Comment on lines +159 to -163
this.profit = profit;

if (this.contract_id !== contract.id) {
this.clear(false);
this.contract_id = contract.id;
this.profit = profit;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need the value of each transaction of the profit field relative to one contract, not just the first one

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17627](https://github.com/deriv-com/deriv-app/pull/17627)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-grwt-2382.binary.sx?qa_server=red.derivws.com&app_id=23883
    - **Original**: https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-grwt-2382.binary.sx
- **App ID**: `23883`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-grwt-2382.binary.sx/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11953782441

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.896%

Totals Coverage Status
Change from base Build 11951696863: 0.0%
Covered Lines: 32659
Relevant Lines: 56568

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants