-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOT]maryia/GRWT-2382/fix: Run panel animation result does not match contact result on win/loss #17627
base: master
Are you sure you want to change the base?
[BOT]maryia/GRWT-2382/fix: Run panel animation result does not match contact result on win/loss #17627
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
this.profit = profit; | ||
|
||
if (this.contract_id !== contract.id) { | ||
this.clear(false); | ||
this.contract_id = contract.id; | ||
this.profit = profit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need the value of each transaction of the profit field relative to one contract, not just the first one
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-grwt-2382.binary.sx/ |
Pull Request Test Coverage Report for Build 11953782441Details
💛 - Coveralls |
Changes:
fix: Run panel animation result does not match contact result on win/loss
!we need the value of each transaction of the profit field relative to one contract, not just the first one
Screenshots:
Please provide some screenshots of the change.