test: Memory leak fix in act runner

[pswitchy]

I resolved the MaxListenersExceededWarning by identifying that process.on('exit') listeners were being leaked in each test file. By switching from driver.close() to driver.quit(), I ensured that the ChromeDriver child process is fully terminated rather than just closing the browser window.

1. Robust Teardown Logic

To prevent EADDRINUSE errors and handle cases where the driver might crash, I wrapped the teardown in a try/catch/finally block. This guarantees the server closes even if the driver fails to quit.

after(async () => {
  try {
    // I switched to .quit() to kill the process and clear listeners
    if (driver) await driver.quit();
  } catch (err) {
    console.error('Error quitting driver:', err.message);
  } finally {
    // I use finally to ensure the server always releases the port
    if (server) await new Promise(r => server.close(r));
  }
});

2. My CI Stress Test Configuration

To prove the stability of my fix, I modified the GitHub Actions workflow. I added a strategy matrix to force the suite to run 10 times concurrently on every PR.

test_act:
    runs-on: ubuntu-24.04
    strategy:
      fail-fast: false # I disabled fail-fast so all 10 runs must complete
      matrix:
        run_number: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
    steps:
      - name: Run ACT test suite
        run: npm run test:act

Closes:
#5018

[CLAassistant]

All committers have signed the CLA.

[pswitchy]

@straker could you review this?

[straker]

Thanks for pr. Once the tests runs the 10x and we've shown it doesn't error, we'll need you to remove the 10x runner before we merge.

[pswitchy]

Thanks for pr. Once the tests runs the 10x and we've shown it doesn't error, we'll need you to remove the 10x runner before we merge.

chrome is crashing in these tests, do you need me to do this right now, or do i try to fix the issue first?

[stephenmathieson]

This needs to be removed prior to merging.

[stephenmathieson]

This is a good fix, but this PR is incomplete. test/aria-practices/apg.spec.js has the same problem. Could you please update it too?

[stephenmathieson]

These are reasonable additions, but adding them seems unrelated to this PR.

[straker]

@pswitchy So testing this out further I don't think this fix by itself fixes the problem. Even after adding @stephenmathieson additions to add the options it still fails. I'm going to close this pr and take on figuring out what to do. My guess is something similar to axe-core-npm and pin the chrome/driver version, but that will be a bit more work in this repo.