Skip to content

test: fix chromedriver 146 failing to create session#5026

Merged
dylanb merged 8 commits into
developfrom
fix-chromedriver-146
Mar 7, 2026
Merged

test: fix chromedriver 146 failing to create session#5026
dylanb merged 8 commits into
developfrom
fix-chromedriver-146

Conversation

@straker
Copy link
Copy Markdown
Contributor

@straker straker commented Mar 5, 2026

Similar to our fix in axe-core-npm this pins chrome/driver to v145 in order to fix the failing tests due to chromedriver crashing or failing to create a session. It also fixes the memory issue in #5018 and adds some chrome options that are good for ci usage. I also created a tech debt ticket to track the pin.

See https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 that it shows 10 successful runs.

Closes: #501

@straker straker marked this pull request as ready for review March 5, 2026 16:35
@straker straker requested a review from a team as a code owner March 5, 2026 16:35
@straker straker marked this pull request as draft March 5, 2026 20:40
@straker
Copy link
Copy Markdown
Contributor Author

straker commented Mar 5, 2026

https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 Shows pinning to chrome/driver v145 is the fix to get this to pass gain. Everything else is nice to have.

@straker straker marked this pull request as ready for review March 5, 2026 21:30
Comment thread .github/actions/install-deps/action.yml
@dylanb dylanb merged commit 88c3676 into develop Mar 7, 2026
23 checks passed
@dylanb dylanb deleted the fix-chromedriver-146 branch March 7, 2026 11:51
dylanb pushed a commit that referenced this pull request Mar 7, 2026
Similar to our fix in
[axe-core-npm](dequelabs/axe-core-npm#1291) this
pins chrome/driver to v145 in order to fix the failing tests due to
chromedriver crashing or failing to create a session. It also fixes the
memory issue in #5018 and
adds some chrome options that are good for ci usage. I also created a
tech debt ticket to track the pin.

See
https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026
that it shows 10 successful runs.

Closes: #501
WilcoFiers pushed a commit that referenced this pull request Mar 30, 2026
Similar to our fix in
[axe-core-npm](dequelabs/axe-core-npm#1291) this
pins chrome/driver to v145 in order to fix the failing tests due to
chromedriver crashing or failing to create a session. It also fixes the
memory issue in #5018 and
adds some chrome options that are good for ci usage. I also created a
tech debt ticket to track the pin.

See
https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026
that it shows 10 successful runs.

Closes: #501
straker added a commit that referenced this pull request Mar 30, 2026
Similar to our fix in
[axe-core-npm](dequelabs/axe-core-npm#1291) this
pins chrome/driver to v145 in order to fix the failing tests due to
chromedriver crashing or failing to create a session. It also fixes the
memory issue in #5018 and
adds some chrome options that are good for ci usage. I also created a
tech debt ticket to track the pin.

See
https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026
that it shows 10 successful runs.

Closes: #501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make results better for calculating metrics based on passes and failures

4 participants