test: fix chromedriver 146 failing to create session#5026
Merged
Conversation
Contributor
Author
|
https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 Shows pinning to chrome/driver v145 is the fix to get this to pass gain. Everything else is nice to have. |
stephenmathieson
previously requested changes
Mar 5, 2026
dylanb
approved these changes
Mar 7, 2026
dylanb
pushed a commit
that referenced
this pull request
Mar 7, 2026
Similar to our fix in [axe-core-npm](dequelabs/axe-core-npm#1291) this pins chrome/driver to v145 in order to fix the failing tests due to chromedriver crashing or failing to create a session. It also fixes the memory issue in #5018 and adds some chrome options that are good for ci usage. I also created a tech debt ticket to track the pin. See https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 that it shows 10 successful runs. Closes: #501
WilcoFiers
pushed a commit
that referenced
this pull request
Mar 30, 2026
Similar to our fix in [axe-core-npm](dequelabs/axe-core-npm#1291) this pins chrome/driver to v145 in order to fix the failing tests due to chromedriver crashing or failing to create a session. It also fixes the memory issue in #5018 and adds some chrome options that are good for ci usage. I also created a tech debt ticket to track the pin. See https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 that it shows 10 successful runs. Closes: #501
straker
added a commit
that referenced
this pull request
Mar 30, 2026
Similar to our fix in [axe-core-npm](dequelabs/axe-core-npm#1291) this pins chrome/driver to v145 in order to fix the failing tests due to chromedriver crashing or failing to create a session. It also fixes the memory issue in #5018 and adds some chrome options that are good for ci usage. I also created a tech debt ticket to track the pin. See https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 that it shows 10 successful runs. Closes: #501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to our fix in axe-core-npm this pins chrome/driver to v145 in order to fix the failing tests due to chromedriver crashing or failing to create a session. It also fixes the memory issue in #5018 and adds some chrome options that are good for ci usage. I also created a tech debt ticket to track the pin.
See https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 that it shows 10 successful runs.
Closes: #501