ci: pin to chrome/driver 145#1291
Merged
Merged
Conversation
Member
|
I wonder if the 146 thing is because an older Chrome is on the runner images. Might be Chrome's control API had a breaking change and you need to update in lockstep. One more reason we need to refactor all the CI eventually to use browser-actions/setup-chrome where we don't use containers to run CI in. That action keeps the browser and driver in sync, regardless of what is on he host box. |
Garbee
approved these changes
Mar 5, 2026
Contributor
Author
|
|
This was referenced Mar 5, 2026
dylanb
pushed a commit
to dequelabs/axe-core
that referenced
this pull request
Mar 7, 2026
Similar to our fix in [axe-core-npm](dequelabs/axe-core-npm#1291) this pins chrome/driver to v145 in order to fix the failing tests due to chromedriver crashing or failing to create a session. It also fixes the memory issue in #5018 and adds some chrome options that are good for ci usage. I also created a tech debt ticket to track the pin. See https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 that it shows 10 successful runs. Closes: #501
dylanb
pushed a commit
to dequelabs/axe-core
that referenced
this pull request
Mar 7, 2026
Similar to our fix in [axe-core-npm](dequelabs/axe-core-npm#1291) this pins chrome/driver to v145 in order to fix the failing tests due to chromedriver crashing or failing to create a session. It also fixes the memory issue in #5018 and adds some chrome options that are good for ci usage. I also created a tech debt ticket to track the pin. See https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 that it shows 10 successful runs. Closes: #501
chutchins25
approved these changes
Mar 9, 2026
chutchins25
left a comment
chutchins25
left a comment
There was a problem hiding this comment.
Looks good to me! A nice, small change!
WilcoFiers
pushed a commit
to dequelabs/axe-core
that referenced
this pull request
Mar 30, 2026
Similar to our fix in [axe-core-npm](dequelabs/axe-core-npm#1291) this pins chrome/driver to v145 in order to fix the failing tests due to chromedriver crashing or failing to create a session. It also fixes the memory issue in #5018 and adds some chrome options that are good for ci usage. I also created a tech debt ticket to track the pin. See https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 that it shows 10 successful runs. Closes: #501
straker
added a commit
to dequelabs/axe-core
that referenced
this pull request
Mar 30, 2026
Similar to our fix in [axe-core-npm](dequelabs/axe-core-npm#1291) this pins chrome/driver to v145 in order to fix the failing tests due to chromedriver crashing or failing to create a session. It also fixes the memory issue in #5018 and adds some chrome options that are good for ci usage. I also created a tech debt ticket to track the pin. See https://github.com/dequelabs/axe-core/actions/runs/22737133182?pr=5026 that it shows 10 successful runs. Closes: #501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears chrome/driver v146 has issues and is consistently crashing or failing to create a session in our webdriverjs & cli tests (which uses webdriverjs). Trying to figure out the problem didn't result in figuring out what went wrong so I'm just pinning to v145 which still passes the tests. Hopefully this will be resolved in future versions, but I'll create a tech-debt ticket to look back at this.
This also brings in @Garbee changes to fix the lockfile as both problems are blocking tests.
No QA required