Skip to content

test: Memory leak fix in act runner #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pswitchy wants to merge 2 commits into from
Closed

test: Memory leak fix in act runner #5025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
867d6c8
Memory leak fix in act runner
pswitchy Mar 4, 2026
4324a83
fixing test-act flakiness
pswitchy Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,10 @@ jobs:
runs-on: ubuntu-24.04
timeout-minutes: 10
needs: build
strategy:
fail-fast: false
matrix:
run_number: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
Comment on lines +134 to +137
Copy link
Copy Markdown
Member

@stephenmathieson stephenmathieson Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed prior to merging.

steps:
- *checkout
- *install-deps
Expand Down
9 changes: 7 additions & 2 deletions test/act-rules/act-runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,13 @@ module.exports = ({ id, title, axeRules, skipTests = [] }) => {
});

after(async () => {
await driver.close();
await new Promise(r => server.close(r));
try {
if (driver) await driver.quit();
Copy link
Copy Markdown
Member

@stephenmathieson stephenmathieson Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix, but this PR is incomplete. test/aria-practices/apg.spec.js has the same problem. Could you please update it too?

} catch (err) {
console.error('Error quitting driver:', err.message);
} finally {
if (server) await new Promise(r => server.close(r));
}
});

testcases.forEach(testcase => {
Expand Down
7 changes: 6 additions & 1 deletion test/get-webdriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ const chromedriverPath =

const getWebdriver = () => {
const service = new chrome.ServiceBuilder(chromedriverPath);
const options = new chrome.Options().addArguments('--headless');
const options = new chrome.Options().addArguments([
'--headless',
'--no-sandbox',
'--disable-extensions',
'--disable-dev-shm-usage'
]);
Comment on lines +8 to +13
Copy link
Copy Markdown
Member

@stephenmathieson stephenmathieson Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are reasonable additions, but adding them seems unrelated to this PR.


if (process.env.CHROME_BIN) {
options.setBinaryPath(process.env.CHROME_BIN);
Expand Down
Loading