Fix parsing some YAMLs due to outdated libyaml#7112
Conversation
28f39cf to
4069b91
Compare
brrygrdn
left a comment
There was a problem hiding this comment.
This upgrade makes sense to me!
Regarding the test failures, the Updater spec failure looks like we might have a new flake potentially introduced by #7075 - it's worth rebasing/merging main to see if it clears up just in case but we might need to go look at that.
|
I hope it will be good after #7113 🤞. |
4069b91 to
58249a7
Compare
|
Well, that didn't do the trick. Hopefully it's fine after #7114. |
5e11cae to
fe1c1c9
Compare
jeffwidman
left a comment
There was a problem hiding this comment.
Seems fine to me.
It looks like Focal (which we're on now) and Jammy (which we'll be moving to in #5030) both pull in 0.2.2 but starting in Kinetic (22.10) libyaml-dev defaults to 0.2.5: https://packages.ubuntu.com/search?suite=default§ion=all&arch=any&keywords=libyaml-dev&searchon=names
Dockerfile.updater-core
Outdated
There was a problem hiding this comment.
Should this change happen regardless of the libyaml bump? Or does somehow nuking the entire ~/.bundle dir help with docker image caching more than nuking ~/.bundle/cache?
There was a problem hiding this comment.
It's because I need to configure Bundler globally to use the downloaded sources and the previous rm -rf ~/.bundle would wipe out the configuration, which is also needed when installing gems from omnibus/.
9dcc65e to
97a5c98
Compare
97a5c98 to
56b5383
Compare
While working on PNPM, I was going crazy because Dependabot could not parse the following YAML file: https://github.com/ice-lab/icestark/blob/ec2d44244a2b4ebd7af0e0ff0a10f528b33b8a64/pnpm-lock.yaml However, it would be parsed just fine on my dev machine. After investigating, turns out I was using a newer version of libyaml locally, which must've corrected some bugs. Unfortunately, updating the underlying libyaml is painful, but I think it can be done, so this is my take at it. An alternative approach would be to avoid parsing YAML. For my purposes is doable, since I just wanted to detect the version used by the PNPM lockfile and that can be figured out pretty reliably without parsing YAML. But I was worried that this could be biting us in other places so I'm trying to upgrade libyaml.
56b5383 to
df47240
Compare
While working on PNPM, I was going crazy because Dependabot could not parse the following YAML file:
https://github.com/ice-lab/icestark/blob/ec2d44244a2b4ebd7af0e0ff0a10f528b33b8a64/pnpm-lock.yaml
However, it would be parsed just fine on my dev machine.
On my dev machine:
On the development container:
After investigating, turns out I was using a newer version of libyaml locally, which must've corrected some bugs.
Unfortunately, updating the underlying libyaml is painful, but I think it can be done, so this is my take at it.
An alternative approach would be to avoid parsing YAML. For my purposes is doable, since I just wanted to detect the version used by the PNPM lockfile and that can be figured out pretty reliably without parsing YAML. But I was worried that this could be biting us in other places so I'm trying to upgrade libyaml.