Merged
Conversation
Clear side effects in `DependencyGroupEngine` after the spec that causes them.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/updater-specs
branch
from
5a000e8 to
42a1636
Compare
landongrindheim
approved these changes
Apr 19, 2023
Contributor
Author
|
Thanks ❤️ |
Member
Oof, nice catch! 😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducer:
There was one spec causing side effects that was missing cleanup.
Also I changed cleaning up side effects to be done after the specs that create them, not before.