Skip to content

Fix more order dependent spec failures#7114

Merged
deivid-rodriguez merged 2 commits intomainfrom
deivid-rodriguez/more-updater-flakies
Apr 19, 2023
Merged

Fix more order dependent spec failures#7114
deivid-rodriguez merged 2 commits intomainfrom
deivid-rodriguez/more-updater-flakies

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez commented Apr 19, 2023

We were also leaking the grouped updates experiment.

Failures can be reproduced with:

$ script/ci-test-updater './spec/dependabot/dependency_group_engine_spec.rb:129' './spec/dependabot/update_files_command_spec.rb:52' --order=defined

@deivid-rodriguez deivid-rodriguez merged commit 32811c0 into main Apr 19, 2023
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/more-updater-flakies branch April 19, 2023 12:30
@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

Thanks again @landongrindheim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants