Skip to content

Remove unnecessary custom libyaml#13008

Merged
kbukum1 merged 2 commits intodependabot:mainfrom
deivid-rodriguez:deivid-rodriguez/revert-libyaml
Sep 11, 2025
Merged

Remove unnecessary custom libyaml#13008
kbukum1 merged 2 commits intodependabot:mainfrom
deivid-rodriguez:deivid-rodriguez/revert-libyaml

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez commented Sep 3, 2025

What are you trying to accomplish?

As per #7112 (review), current ubuntu version ships a modern enough libyaml-dev, so I think #7112 can be mostly revert.

Anything you want to highlight for special attention from reviewers?

I did keep making psych an explicit dependency from #7112, because I believe it's used directly by Dependabot.

How will you know you've accomplished your goal?

CI is good I guess!

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 added auto-merge Batch How We Work: Feature. Outcome achieved within 1 iteration. Can live under an epic, or stand alone. and removed auto-merge Batch How We Work: Feature. Outcome achieved within 1 iteration. Can live under an epic, or stand alone. labels Sep 4, 2025
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/revert-libyaml branch from 939dc14 to 09385b6 Compare September 4, 2025 04:22
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review September 4, 2025 04:22
@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner September 4, 2025 04:22
@kbukum1 kbukum1 merged commit 481edd9 into dependabot:main Sep 11, 2025
268 of 278 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/revert-libyaml branch September 11, 2025 20:36
diofeher pushed a commit to diofeher/dependabot-core that referenced this pull request Sep 16, 2025
Co-authored-by: kbukum1 <kbukum1@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants