fix(rs-drive-abci): start rs-drive-abci using dashmate and pass init_chain - #941
Conversation
5674bcc to
2060b3a
Compare
2060b3a to
7469498
Compare
f3e3b94 to
567521b
Compare
…ending to tenderdash
| }; | ||
|
|
||
| Ok(core_height) | ||
| } |
There was a problem hiding this comment.
Not sure I understand the point here. Let's imagine we send core a height 0 -> it won't work. Let's imagine we send a height it doesn't know about -> non deterministic. I think we would never want the requested height.
There was a problem hiding this comment.
Imagine we are at genesis. We publish tenderdash's genesis.json. We put core chain lock height there. MNOs download that genesis.json and accept it. So we should use that core chain lock height here, as this is the intention of the user (MNO).
We determine core chain locked height ourselves (from fork info) only if user didn't explicitly provide it.
There was a problem hiding this comment.
will add verification of provided core chain lock in #981
| requested: u32, | ||
| fork_info: &Bip9SoftforkInfo, | ||
| ) -> Result<u32, Error> { | ||
| let core_height = if requested != 0 { |
There was a problem hiding this comment.
| let core_height = if requested != 0 { | |
| let core_height = if requested != None { |
There was a problem hiding this comment.
add check if requested is ok in core (TODO for now)
| }; | ||
|
|
||
| Ok(core_height) | ||
| } |
There was a problem hiding this comment.
will add verification of provided core chain lock in #981
…y-wallet rust-dashcore#952 (merged as 9c0e8742) gave the #926 policy a canonical home: AccountType::is_contact_owned(), with an exhaustive match so any future account type must declare whether its coins are the wallet's or a contact's. Bump the workspace pin to the dev tip (37b1a361, which also brings dash-spv sync-reliability fixes #941/#943/#949/#953) and make is_contact_watch_only delegate to the upstream predicate instead of matching DashpayExternalAccount locally. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Issue being fixed or feature implemented
init_chain abci call fails due to:
What was done?
Main solution:
How Has This Been Tested?
using dashmate
Breaking Changes
Checklist:
For repository code-owners and collaborators only