Skip to content

[WIP] ci: testing local/s3 backend for cache - #953

Closed
strophy wants to merge 315 commits into
v0.25-devfrom
feat/faster-ci
Closed

[WIP] ci: testing local/s3 backend for cache#953
strophy wants to merge 315 commits into
v0.25-devfrom
feat/faster-ci

Conversation

@strophy

@strophy strophy commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Testing PR to trigger CI runs, do not merge

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy
strophy changed the base branch from v0.24-dev to v0.25-dev April 28, 2023 05:04
@strophy
strophy changed the base branch from v0.25-dev to feat/wasm-dpp-integration April 28, 2023 05:04
@strophy
strophy marked this pull request as ready for review April 28, 2023 05:05
Base automatically changed from feat/wasm-dpp-integration to v0.25-dev April 28, 2023 09:44
@shumkov shumkov changed the title ci: testing local/s3 backend for sccache [WIP] ci: testing local/s3 backend for sccache Apr 28, 2023
Comment thread packages/dashmate/Dockerfile Outdated
Comment on lines -49 to -54
RUN --mount=type=cache,sharing=private,target=/root/.cache/sccache \
--mount=type=cache,sharing=shared,target=${CARGO_HOME}/registry/index \
--mount=type=cache,sharing=shared,target=${CARGO_HOME}/registry/cache \
--mount=type=cache,sharing=shared,target=${CARGO_HOME}/git/db \
export SCCACHE_SERVER_PORT=$((RANDOM+1025)) && \
yarn workspace @dashevo/wasm-dpp build && \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need this

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it to try and figure out if it was the cause of step #39 errors

@strophy strophy changed the title [WIP] ci: testing local/s3 backend for sccache [WIP] ci: testing local/s3 backend for cache Jun 14, 2023
@shumkov shumkov mentioned this pull request Jun 23, 2023
5 tasks
@shumkov

shumkov commented Jun 23, 2023

Copy link
Copy Markdown
Collaborator

Closed in favor of #1167

@shumkov shumkov closed this Jun 23, 2023
@shumkov
shumkov deleted the feat/faster-ci branch August 25, 2024 08:51
QuantumExplorer added a commit that referenced this pull request Aug 11, 2026
…y-wallet

rust-dashcore#952 (merged as 9c0e8742) gave the #926 policy a canonical
home: AccountType::is_contact_owned(), with an exhaustive match so any
future account type must declare whether its coins are the wallet's or
a contact's. Bump the workspace pin to the dev tip (37b1a361, which
also brings dash-spv sync-reliability fixes #941/#943/#949/#953) and
make is_contact_watch_only delegate to the upstream predicate instead
of matching DashpayExternalAccount locally.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants