fix(dashmate): wrong envoy config path on windows - #949
Merged
Conversation
antouhou
approved these changes
Apr 21, 2023
thephez
changed the title
markin-io
pushed a commit
that referenced
this pull request
Apr 28, 2023
QuantumExplorer
added a commit
that referenced
this pull request
Aug 11, 2026
…y-wallet rust-dashcore#952 (merged as 9c0e8742) gave the #926 policy a canonical home: AccountType::is_contact_owned(), with an exhaustive match so any future account type must declare whether its coins are the wallet's or a contact's. Bump the workspace pin to the dev tip (37b1a361, which also brings dash-spv sync-reliability fixes #941/#943/#949/#953) and make is_contact_watch_only delegate to the upstream predicate instead of matching DashpayExternalAccount locally. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Dashmate throws fatal error
"invalid input" even for valid path for existing certin Windows environmentWhat was done?
Fixed error in filename parsing.
How Has This Been Tested?
Manual
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only