Skip to content

fix(rs-drive-abci): Get rs-drive-abci to commit block 1 - #981

Merged
QuantumExplorer merged 44 commits into
v0.25-devfrom
rs-drive-abci-block-1
Apr 27, 2023
Merged

fix(rs-drive-abci): Get rs-drive-abci to commit block 1#981
QuantumExplorer merged 44 commits into
v0.25-devfrom
rs-drive-abci-block-1

Conversation

@lklimek

@lklimek lklimek commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek added 30 commits April 20, 2023 15:30
Base automatically changed from fix/rs-drive-abci to v0.25-dev April 27, 2023 09:39
@lklimek
lklimek marked this pull request as ready for review April 27, 2023 14:39

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor suggestions

Comment thread packages/rs-drive-abci/src/abci/commit.rs Outdated
Comment thread packages/rs-drive-abci/src/abci/commit.rs Outdated
Comment thread packages/rs-drive-abci/src/abci/handlers.rs Outdated
Comment thread packages/rs-drive-abci/src/execution/engine.rs Outdated
@lklimek
lklimek requested a review from QuantumExplorer April 27, 2023 15:17
Comment thread packages/rs-drive-abci/src/abci/commit.rs
Comment thread packages/rs-drive-abci/src/abci/mimic.rs
Comment thread packages/rs-drive-abci/src/abci/withdrawal.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants