chore: bump version to 3.2.0 and refresh .NET 10 docs#503
Merged
Conversation
Bumps the desktop app and WiX installer from 3.1.0 to 3.2.0 ahead of the v3.2.0 release. Also updates README.md and CLAUDE.md to reflect the .NET 9 → .NET 10 upgrade that landed in #499; the project files have targeted net10.0-windows since that PR. Submodule assemblies (Common, DataModel, IO) remain at 3.0.0.0; they have not been bumped on prior releases either. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Review Summary by QodoBump version to 3.2.0 and update .NET 10 documentation
WalkthroughsDescription• Bump desktop app version from 3.1.0 to 3.2.0 • Update WiX installer version to 3.2.0.0 • Refresh documentation to reflect .NET 10 upgrade • Update assembly and file versions in project file Diagramflowchart LR
A["Version 3.1.0"] -->|"Bump to 3.2.0"| B["Desktop App"]
A -->|"Bump to 3.2.0.0"| C["WiX Installer"]
D[".NET 9.0 References"] -->|"Update to .NET 10.0"| E["Documentation"]
B --> F["AssemblyVersion & FileVersion Updated"]
File Changes1. Daqifi.Desktop/Daqifi.Desktop.csproj
|
Contributor
Code Review by Qodo
1. Tabs in version metadata
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+23
to
+24
| <AssemblyVersion>3.2.0.0</AssemblyVersion> | ||
| <FileVersion>3.2.0.0</FileVersion> |
Contributor
There was a problem hiding this comment.
1. Tabs in version metadata 📘 Rule violation ✧ Quality
The modified .csproj lines use leading tab characters for indentation instead of 4 spaces. This violates the repo rule requiring 4-space indentation with no tabs on changed lines.
Agent Prompt
## Issue description
The modified `.csproj` lines use tab indentation, but the project requires 4 spaces and no tabs.
## Issue Context
The changed `<AssemblyVersion>` and `<FileVersion>` lines include leading tab characters.
## Fix Focus Areas
- Daqifi.Desktop/Daqifi.Desktop.csproj[23-24]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Contributor
Author
There was a problem hiding this comment.
Disagreed — leaving as-is.
This .csproj uses tab indentation throughout (lines 3–32), and the version-bump diff preserved the surrounding convention. Converting only the two changed lines to 4 spaces would produce mixed indentation in a single <PropertyGroup> block, which is worse than the current consistent style.
The CLAUDE.md "4 spaces" rule lives under the Code Style section alongside C#-specific guidance (Allman braces, regions, etc.) and applies to source code; project XML files in this repo follow their own tab convention. Reformatting the whole file to spaces is out of scope for a release-prep PR. Happy to do a separate chore: normalize project-file indentation PR if the team wants that across all .csproj files.
Comment on lines
+23
to
+24
| <AssemblyVersion>3.2.0.0</AssemblyVersion> | ||
| <FileVersion>3.2.0.0</FileVersion> |
Contributor
There was a problem hiding this comment.
2. Manifest version mismatch 🐞 Bug ≡ Correctness
The app’s embedded manifest still declares assemblyIdentity version 3.1.0.0 even though the PR bumps the app’s AssemblyVersion/FileVersion to 3.2.0.0, producing inconsistent shipped identity/metadata. This mismatch is introduced by the version bump without updating the referenced ApplicationManifest file.
Agent Prompt
### Issue description
The app embeds `Daqifi.Desktop/app.manifest`, but its `<assemblyIdentity version>` is still `3.1.0.0` while the project now produces `3.2.0.0` assembly/file versions.
### Issue Context
This PR updates the app/installer versions to 3.2.0.0; the embedded Windows manifest should be kept in sync to avoid conflicting identity/version metadata.
### Fix Focus Areas
- Daqifi.Desktop/app.manifest[1-5]
- Daqifi.Desktop/Daqifi.Desktop.csproj[17-25]
### Proposed fix
Update `app.manifest`:
- Change `<assemblyIdentity version="3.1.0.0" .../>` to `<assemblyIdentity version="3.2.0.0" .../>`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Contributor
Author
There was a problem hiding this comment.
Fixed in 5e395df. Bumped assemblyIdentity version in Daqifi.Desktop/app.manifest from 3.1.0.0 to 3.2.0.0 so the embedded manifest matches AssemblyVersion/FileVersion.
Bumps the embedded Windows manifest's assemblyIdentity version to 3.2.0.0 so the shipped EXE's manifest no longer disagrees with its AssemblyVersion/FileVersion. Adds an explicit `actions/setup-dotnet@v5` step to build.yaml pinning .NET 10.0.x, matching what release.yaml already does. This makes the README's "all workflows run on .NET 10.0" claim true by construction rather than relying on whatever SDK happens to be on the runner. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
Qodo review responsesGoing through the 3 items in the review summary:
|
📊 Code Coverage ReportSummarySummary
CoverageDAQiFi - 17.6%
Daqifi.Desktop.Common - 30.8%
Daqifi.Desktop.IO - 100%
Coverage report generated by ReportGenerator • View full report in build artifacts |
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net10.0-windowssince that PR but the docs hadn't caught up.Test plan
FileVersion 3.2.0.0(right-click → Properties → Details on the builtDAQiFi.exe)3.2.0.0and that an upgrade from a 3.1.x install replaces it cleanly🤖 Generated with Claude Code