Conversation
The only breaking change in 0.20.0 is dropping net8.0; desktop targets net10.0(-windows) across all projects, so no code changes were required. The release also adds a new Daqifi.Core.Logging.Export namespace which is purely additive. Release notes: https://github.com/daqifi/daqifi-core/releases/tag/v0.20.0 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Review Summary by QodoBump Daqifi.Core to 0.20.0 across desktop projects
WalkthroughsDescription• Bump Daqifi.Core from 0.19.7 to 0.20.0 across three projects • Adds new Daqifi.Core.Logging.Export namespace for CSV export pipeline • Drops net8.0 support; all projects target net10.0 or net10.0-windows • No code changes required; purely additive API surface Diagramflowchart LR
A["Daqifi.Core 0.19.7"] -- "upgrade" --> B["Daqifi.Core 0.20.0"]
B -- "adds" --> C["Logging.Export namespace"]
B -- "drops" --> D["net8.0 support"]
E["Daqifi.Desktop"] -- "updated" --> B
F["Daqifi.Desktop.DataModel"] -- "updated" --> B
G["Daqifi.Desktop.IO"] -- "updated" --> B
File Changes1. Daqifi.Desktop.DataModel/Daqifi.Desktop.DataModel.csproj
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
📊 Code Coverage ReportSummarySummary
CoverageDAQiFi - 17.6%
Daqifi.Desktop.Common - 30.8%
Daqifi.Desktop.IO - 100%
Coverage report generated by ReportGenerator • View full report in build artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
Daqifi.Coredevice-protocol/HAL package from 0.19.7 → 0.20.0 in the three csproj files that reference it (Daqifi.Desktop,Daqifi.Desktop.DataModel,Daqifi.Desktop.IO). All three were kept in lockstep.Upstream release notes: https://github.com/daqifi/daqifi-core/releases/tag/v0.20.0
What's in 0.19.7 → 0.20.0
There are no intermediate releases between 0.19.7 and 0.20.0, so this is a single release-note hop.
Daqifi.Core.Logging.Exportnamespace (ISampleSource,ChannelDescriptor,SampleRow,CsvExporter, etc.) — storage-agnostic CSV export pipeline (core#167)net8.0support — package now shipsnet9.0andnet10.0only (core#175)net10.0ornet10.0-windows(PR #499 / PR #503 already migrated us off net9)Net result: zero code changes required here. Single bump commit; no follow-up
refactor:/fix:commit was needed.Verification
ISampleSource/ChannelDescriptor/SampleRow/CsvExporter/Logging.Export— no collisions with existing types.Daqifi.Coreconsumption (Communication.*,Device.*,Channel.*,Firmware.*) is untouched by 0.20.0.dotnet restore✅dotnet build --configuration Release /p:EnforceCodeStyleInBuild=true✅ — 0 errors. Warning count unchanged frommain(all pre-existing CS86xx/CA*/MSTEST0032 in test code).dotnet test --configuration Release --no-buildpartial:Daqifi.Desktop.IO.Testran on macOS-arm64 and passed (1/1). The other three test assemblies need an x64 .NET host (the main app is<PlatformTarget>x64</PlatformTarget>for Windows/WPF), which isn't available on this dev machine — the full suite needs to run in CI on Windows.Test plan
Daqifi.Coreis the device-protocol/HAL library — high blast radius. Please verify on Windows hardware:.binlog session from an SD card and confirm samples land in the desktop DBdotnet testgo greenNotes / risks
Daqifi.Coreis the highest-blast-radius dependency in the project, so even though the diff is three lines, please prioritise the on-hardware checks above before merging.🤖 Generated with Claude Code