Skip to content

chore: bump version to 3.2.0 and refresh .NET 10 docs #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylerkron merged 2 commits into from
Apr 26, 2026
Merged

chore: bump version to 3.2.0 and refresh .NET 10 docs #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
276411e
chore: bump version to 3.2.0 and refresh .NET 10 references in docs
tylerkron Apr 26, 2026
5e395df
fix: address Qodo review — sync app.manifest version, pin build SDK
tylerkron Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ jobs:
steps:
- uses: actions/checkout@v6

- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
dotnet-version: 10.0.x

- name: Cache NuGet packages
uses: actions/cache@v5
with:
Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This document provides context for Claude to assist with the DAQiFi Desktop appl
DAQiFi Desktop is a Windows desktop application for communicating with DAQiFi hardware products. Our goal is to modernize data acquisition with user-friendly and intuitive products.

### Technology Stack
- .NET 9.0 and WPF for the desktop application
- .NET 10.0 and WPF for the desktop application
- SQLite for local data storage
- Google Protocol Buffers for device communication
- EntityFramework for database operations
Expand Down
2 changes: 1 addition & 1 deletion Daqifi.Desktop.Setup/DAQifiDesktopSetup/Product.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
xmlns:ui="http://wixtoolset.org/schemas/v4/wxs/ui">
<Package Name="DAQiFi"
Manufacturer="DAQiFi"
Version="3.1.0.0"
Version="3.2.0.0"
UpgradeCode="ACA4F4E1-6DBB-47C0-A829-84AA1536C147"
Language="1033">

Expand Down
6 changes: 3 additions & 3 deletions Daqifi.Desktop/Daqifi.Desktop.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<UseWPF>true</UseWPF>
<UseWindowsForms>true</UseWindowsForms>
<Version>3.1.0</Version>
<Version>3.2.0</Version>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<InternalsVisibleTo>Daqifi.Desktop.Test</InternalsVisibleTo>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand All @@ -20,8 +20,8 @@
<EnableWindowsTargeting>true</EnableWindowsTargeting>
</PropertyGroup>
<PropertyGroup>
<AssemblyVersion>3.1.0.0</AssemblyVersion>
<FileVersion>3.1.0.0</FileVersion>
<AssemblyVersion>3.2.0.0</AssemblyVersion>
<FileVersion>3.2.0.0</FileVersion>
Comment on lines +23 to +24
Copy link
Copy Markdown
Contributor

@qodo-code-review qodo-code-review Bot Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Tabs in version metadata 📘 Rule violation ✧ Quality

The modified .csproj lines use leading tab characters for indentation instead of 4 spaces. This
violates the repo rule requiring 4-space indentation with no tabs on changed lines.
Agent Prompt 
## Issue description
The modified `.csproj` lines use tab indentation, but the project requires 4 spaces and no tabs.

## Issue Context
The changed `<AssemblyVersion>` and `<FileVersion>` lines include leading tab characters.

## Fix Focus Areas
- Daqifi.Desktop/Daqifi.Desktop.csproj[23-24]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Copy link
Copy Markdown
Contributor Author

@tylerkron tylerkron Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagreed — leaving as-is.

This .csproj uses tab indentation throughout (lines 3–32), and the version-bump diff preserved the surrounding convention. Converting only the two changed lines to 4 spaces would produce mixed indentation in a single <PropertyGroup> block, which is worse than the current consistent style.

The CLAUDE.md "4 spaces" rule lives under the Code Style section alongside C#-specific guidance (Allman braces, regions, etc.) and applies to source code; project XML files in this repo follow their own tab convention. Reformatting the whole file to spaces is out of scope for a release-prep PR. Happy to do a separate chore: normalize project-file indentation PR if the team wants that across all .csproj files.

Comment on lines +23 to +24
Copy link
Copy Markdown
Contributor

@qodo-code-review qodo-code-review Bot Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Manifest version mismatch 🐞 Bug ≡ Correctness

The app’s embedded manifest still declares assemblyIdentity version 3.1.0.0 even though the PR bumps
the app’s AssemblyVersion/FileVersion to 3.2.0.0, producing inconsistent shipped identity/metadata.
This mismatch is introduced by the version bump without updating the referenced ApplicationManifest
file.
Agent Prompt 
### Issue description
The app embeds `Daqifi.Desktop/app.manifest`, but its `<assemblyIdentity version>` is still `3.1.0.0` while the project now produces `3.2.0.0` assembly/file versions.

### Issue Context
This PR updates the app/installer versions to 3.2.0.0; the embedded Windows manifest should be kept in sync to avoid conflicting identity/version metadata.

### Fix Focus Areas
- Daqifi.Desktop/app.manifest[1-5]
- Daqifi.Desktop/Daqifi.Desktop.csproj[17-25]

### Proposed fix
Update `app.manifest`:
- Change `<assemblyIdentity version="3.1.0.0" .../>` to `<assemblyIdentity version="3.2.0.0" .../>`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Copy link
Copy Markdown
Contributor Author

@tylerkron tylerkron Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 5e395df. Bumped assemblyIdentity version in Daqifi.Desktop/app.manifest from 3.1.0.0 to 3.2.0.0 so the embedded manifest matches AssemblyVersion/FileVersion.

</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
<PlatformTarget>x64</PlatformTarget>
Expand Down
2 changes: 1 addition & 1 deletion Daqifi.Desktop/app.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1">
<assemblyIdentity version="3.1.0.0" name="MyApplication.app"/>
<assemblyIdentity version="3.2.0.0" name="MyApplication.app"/>
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v2">
<security>
<requestedPrivileges xmlns="urn:schemas-microsoft-com:asm.v3">
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Windows desktop application (.NET) that is used to communicate with DAQiFi hardw

## Tech Stack

- .NET 9.0
- .NET 10.0
- WPF
- SQLite

Expand All @@ -26,7 +26,7 @@ The project uses GitHub Actions for continuous integration and deployment:
- **Release**: Automatic release asset publishing when GitHub releases are created
- **Dependency Updates**: Dependabot manages NuGet and GitHub Actions dependencies weekly

All workflows run on .NET 9.0 with Windows runners for WPF compatibility.
All workflows run on .NET 10.0 with Windows runners for WPF compatibility.

## Observability

Expand Down
Loading