Merged
Conversation
- Bumps TargetFramework to net10.0 / net10.0-windows across all projects - Upgrades EF Core packages (Core, Sqlite, Tools) from 9.0.14 → 10.0.7 - Upgrades EFCore.BulkExtensions.Sqlite from 9.0.2 → 10.0.1 - Updates global.json SDK minimum from 9.0.0 → 10.0.0 (both root and Setup) Closes #498 — which was a mismatched partial bump of only the Tools package. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Review Summary by QodoUpgrade .NET framework and dependencies from 9.0 to 10.0
WalkthroughsDescription• Upgrade all 8 projects from .NET 9.0 to .NET 10.0 target framework • Update EF Core packages (Core, Sqlite, Tools) from 9.0.14 to 10.0.7 • Upgrade EFCore.BulkExtensions.Sqlite from 9.0.2 to 10.0.1 • Update global.json SDK minimum version to 10.0.0 in both locations Diagramflowchart LR
A["All 8 Projects<br/>net9.0 → net10.0"] --> B["Target Framework Updated"]
C["EF Core Packages<br/>9.0.14 → 10.0.7"] --> D["Dependencies Upgraded"]
E["EFCore.BulkExtensions<br/>9.0.2 → 10.0.1"] --> D
F["global.json SDK<br/>9.0.0 → 10.0.0"] --> G["SDK Requirement Updated"]
B --> H["Complete .NET 10 Migration"]
D --> H
G --> H
File Changes1. Daqifi.Desktop.Common.Test/Daqifi.Desktop.Common.Test.csproj
|
Contributor
Code Review by Qodo
1. Tab-indented <TargetFramework> line
|
System.Runtime.CompilerServices.Unsafe and System.ValueTuple are part of the .NET 10 runtime — no longer needed as explicit package references. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
- WiX DaqifiSourceDir was still pointing to net9.0-windows\publish - release.yaml was installing .NET SDK 9.0.x and publishing to net9.0-windows path Both would cause the MSI installer build to fail after the .NET 10 upgrade. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📊 Code Coverage ReportSummarySummary
CoverageDAQiFi - 17.6%
Daqifi.Desktop.Common - 30.8%
Daqifi.Desktop.IO - 100%
Coverage report generated by ReportGenerator • View full report in build artifacts |
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TargetFrameworktonet10.0/net10.0-windowsacross all 8 projectsMicrosoft.EntityFrameworkCore,.Sqlite,.Tools) from9.0.14→10.0.7EFCore.BulkExtensions.Sqlitefrom9.0.2→10.0.1global.jsonfiles (root andDaqifi.Desktop.Setup) to require SDK10.0.0minimumCloses #498 — Dependabot's PR only bumped the Tools package to v10 while leaving the runtime packages on v9, which would have caused a version mismatch. This PR completes the full upgrade together.
Test plan
winget install Microsoft.DotNet.SDK.10on Windows orbrew install --cask dotnet-sdkon macOS)dotnet buildsucceeds with no errorsdotnet testpasses all existing tests🤖 Generated with Claude Code