Skip to content

Conversation

@kieran-ryan
Copy link
Member

@kieran-ryan kieran-ryan commented Mar 18, 2024

🤔 What's changed?

  • Made the Cucumber Expressions parameter type optional with the Python implementation

⚡️ What's your motivation?

  • Matches the JavaScript implementation of casting to type by default if a transformer is not explicitly specified (see fix: ParameterType constructor #178)
  • Improves user experience, removing a common use case to simply cast to the type - without further transformation. This improves code quality and maintainability.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@kieran-ryan kieran-ryan added the ⚡ enhancement Request for new functionality label Mar 18, 2024
@kieran-ryan kieran-ryan self-assigned this Mar 18, 2024
@kieran-ryan kieran-ryan added 🐛 bug Defect / Bug and removed ⚡ enhancement Request for new functionality labels Mar 18, 2024
@kieran-ryan kieran-ryan marked this pull request as ready for review March 18, 2024 15:53
@mpkorstanje mpkorstanje merged commit 31e58f3 into main Mar 18, 2024
@mpkorstanje mpkorstanje deleted the optional-transformer branch March 18, 2024 21:53
@mpkorstanje
Copy link
Contributor

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Defect / Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants