Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## [Unreleased]
### Fixed
- [Python] Remove support for Python 3.7 and extend support to 3.12 ([#280](https://github.com/cucumber/cucumber-expressions/pull/280))
- [Python] The `ParameterType` constructor's `transformer` should be optional ([#288](https://github.com/cucumber/cucumber-expressions/pull/288))

## [17.0.2] - 2024-02-20
### Changed
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ ParameterType(
name= "color",
regexp= "red|blue|yellow",
type= Color,
transformer= lambda s: Color(),
transformer= lambda s: Color(s),
)
```

Expand Down
1 change: 1 addition & 0 deletions python/.gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
__pycache__
venv/
# Pytest
.pytest_cache
6 changes: 3 additions & 3 deletions python/cucumber_expressions/parameter_type.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import annotations

import re
from typing import Pattern
from typing import Callable, Optional, Pattern

from cucumber_expressions.errors import CucumberExpressionError

Expand Down Expand Up @@ -47,7 +47,7 @@ def __init__(
name,
regexp,
type,
transformer,
transformer: Optional[Callable] = None,
use_for_snippets: bool = True,
prefer_for_regexp_match: bool = False,
):
Expand All @@ -69,7 +69,7 @@ def __init__(
if self.name:
self._check_parameter_type_name(self.name)
self.type = type
self.transformer = transformer
self.transformer = transformer or (lambda value: type(value))
self._use_for_snippets = use_for_snippets
self._prefer_for_regexp_match = prefer_for_regexp_match
self.regexps = self.to_array(regexp)
Expand Down
17 changes: 17 additions & 0 deletions python/tests/test_custom_parameter_type.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,23 @@ def test_matches_parameters_with_custom_parameter_type(self):
transformed_argument_value = expression.match("I have a red ball")[0]
assert transformed_argument_value.value == Color("red")

def test_casts_to_type_without_transformer(
self,
):
parameter_type_registry = ParameterTypeRegistry()
parameter_type_registry.define_parameter_type(
ParameterType(
"color",
r"red|blue|yellow",
Color,
)
)
expression = CucumberExpression(
"I have a {color} ball", parameter_type_registry
)
argument_value = expression.match("I have a red ball")[0].value
assert argument_value == Color("red")

def test_matches_parameters_without_snippet_and_regex_parameters(
self,
):
Expand Down