python: optional transformer argument for parameter types (#288)

Author: kieran-ryan

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ## [Unreleased]
 ### Fixed
 - [Python] Remove support for Python 3.7 and extend support to 3.12 ([#280](https://github.com/cucumber/cucumber-expressions/pull/280))
+- [Python] The `ParameterType` constructor's `transformer` should be optional ([#288](https://github.com/cucumber/cucumber-expressions/pull/288))
 
 ## [17.0.2] - 2024-02-20
 ### Changed

README.md

@@ -165,7 +165,7 @@ ParameterType(
   name=        "color",
   regexp=      "red|blue|yellow",
   type=        Color,
-  transformer= lambda s: Color(),
+  transformer= lambda s: Color(s),
 )
 ```
 

python/.gitignore

@@ -1,3 +1,4 @@
+__pycache__
 venv/
 # Pytest
 .pytest_cache

python/cucumber_expressions/parameter_type.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import re
-from typing import Pattern
+from typing import Callable, Optional, Pattern
 
 from cucumber_expressions.errors import CucumberExpressionError
 
@@ -47,7 +47,7 @@ def __init__(
         name,
         regexp,
         type,
-        transformer,
+        transformer: Optional[Callable] = None,
         use_for_snippets: bool = True,
         prefer_for_regexp_match: bool = False,
     ):
@@ -69,7 +69,7 @@ def __init__(
         if self.name:
             self._check_parameter_type_name(self.name)
         self.type = type
-        self.transformer = transformer
+        self.transformer = transformer or (lambda value: type(value))
         self._use_for_snippets = use_for_snippets
         self._prefer_for_regexp_match = prefer_for_regexp_match
         self.regexps = self.to_array(regexp)

python/tests/test_custom_parameter_type.py

@@ -62,6 +62,23 @@ def test_matches_parameters_with_custom_parameter_type(self):
         transformed_argument_value = expression.match("I have a red ball")[0]
         assert transformed_argument_value.value == Color("red")
 
+    def test_casts_to_type_without_transformer(
+        self,
+    ):
+        parameter_type_registry = ParameterTypeRegistry()
+        parameter_type_registry.define_parameter_type(
+            ParameterType(
+                "color",
+                r"red|blue|yellow",
+                Color,
+            )
+        )
+        expression = CucumberExpression(
+            "I have a {color} ball", parameter_type_registry
+        )
+        argument_value = expression.match("I have a red ball")[0].value
+        assert argument_value == Color("red")
+
     def test_matches_parameters_without_snippet_and_regex_parameters(
         self,
     ):