Skip to content

Conversation

@unional
Copy link
Contributor

@unional unional commented Oct 27, 2022

🤔 What's changed?

transform, useForSnippets and preferForRegexpMatch can all be optional.

⚡️ What's your motivation?

I'm using this library separately and found this type issue.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

If type can be null, can it be undefined and optional too?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

`transform`, `useForSnippets` and `preferForRegexpMatch` can all be optional.
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please also update the changelog.

@unional
Copy link
Contributor Author

unional commented Oct 31, 2022

Looks good, please also update the changelog.

thx. How do I update the change log? Do I just add an entry under the Unreleased section, or I should use some tools like the polyglot-release or changelog mentioned in https://github.com/cucumber/.github/blob/main/RELEASING.md?

I did this manually
@mpkorstanje
Copy link
Contributor

You can either use changelog fixed .... or manually add it.

@unional
Copy link
Contributor Author

unional commented Oct 31, 2022

You can either use changelog fixed .... or manually add it.

Already added. Please see if that is good enough. thx

@davidjgoss davidjgoss merged commit 99cf694 into cucumber:main Nov 2, 2022
@aslakhellesoy
Copy link
Contributor

Hi @unional,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants