This repository was archived by the owner on Feb 5, 2020. It is now read-only.
Conversation
These are no longer used: - etcd operator / self-hosted etcd was removed. - kubernetes version is no longer needed for kube-core operator.
The smoke tests now include values for these tfvars for testing the CL beta channel, but the GUI will never output the value "beta" for the CL channel, so we need to ignore the vars instead.
config.tf: remove etcd and kubernetes versions.
Consistently use the external link icon for non coreos.com links and don't use it for coreos.com links. The only exception is the on the first wizard page (select platform page). Add ExternalLinkIcon component.
tests/frontend: Ignore tectonic_container_linux_* tfvars in GUI tests
frontend: Remove CSS rule that actually makes vertical alignment worse
…ws-azure aws/azure: bump terraform provider
The 'tectonic-ingress' namespace is needed for ingress operator.
tests/frontend: Update Matchbox credentials for GUI tests
frontend: Use external link icons more consistently
The next test was starting before the diff completed, which could cause the failure to go unreported if the diff was the final test step.
Add #addMore, #awsAdvancedNetworking and #manualBoot id attributes so we don't need to use xpath selectors in Nightwatch.
This commit eliminates platform-specific `select` statements from Golang rules in several BUILD.bazel files. This allows us to workaround Bazel being unable to modify the platform toolchain. Sourcing all of the files for all platforms still results in a correctly compiled binary because rules_go performs file filtering bazel-contrib/rules_go#1148 (comment). TL;DR we no longer need the `tarball` shell script to build a complete Tectonic tarball with binaries for all supported platforms.
tests/frontend: Fix GUI tfvars test to wait until diff is complete
tests/frontend: Add "id" attributes to simplify Nightwatch tests
installer: support declarative x-compile
this will add a new endpoint "/releases/current" to the API which will fetch TECTONIC_VERSION from the build environment and displays the build time in a JSON format.
Installer API: Add buildTime and tectonicVersion
bootkube: Add ingress namespace creation.
buildvars: BUILD_TIME in ISO 8601 format
Remove obsolete git-version script
As per coreos/docs#1142, coreos golang code style has been removed from cores/docs. This commit rewrites the code style recommendation to link to the one maintained by the go community.
Azure: add German locations to fault domain map
|
Can one of the admins verify this patch? |
Contributor
Author
Contributor
|
@enxebre looks like tests are red because bazel build is failing after the rebase |
Contributor
Author
|
@squat |
Contributor
Author
alexsomesan
approved these changes
Feb 15, 2018
Contributor
Author
|
the tectonic binary still does not get generated :/ |
squat
approved these changes
Feb 15, 2018
Contributor
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
LGTM
Also, LGTM on bazel side
Contributor
|
retest this please |
Contributor
Author
|
seems some go deps are missing: |
Contributor
Author
|
Should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge master into ut2-integration