Skip to content
This repository was archived by the owner on Feb 12, 2021. It is now read-only.

rm -r golang#1142

Merged
jzelinskie merged 1 commit intomasterfrom
rm-golang
Sep 1, 2017
Merged

rm -r golang#1142
jzelinskie merged 1 commit intomasterfrom
rm-golang

Conversation

@jzelinskie
Copy link
Contributor

This is not the recommended way to write Go projects and is pointless to
keep around.

This is not the recommended way to write Go projects and is pointless to
keep around.
Copy link
Contributor

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jzelinskie jzelinskie merged commit fe1fac7 into master Sep 1, 2017
@jzelinskie jzelinskie deleted the rm-golang branch September 1, 2017 18:37
@bgilbert
Copy link
Contributor

bgilbert commented Sep 1, 2017

Is there a replacement for the deleted docs?

@euank
Copy link
Contributor

euank commented Sep 1, 2017

@bgilbert as far as I could tell the docs weren't exposed publicly on the website anywhere. I don't think we have a replacement.

We do have the "template project"(https://github.com/coreos/template-project) for some boilerplate, but nothing Go specific.

We could presumably have a "golang" branch of the template project using glide, a makefile, etc as most of our projects do.

@jzelinskie
Copy link
Contributor Author

I think all the projects differ too much. Some things will want to use bazel if they need codegen, dep, glide, etc...

@bgilbert
Copy link
Contributor

bgilbert commented Sep 1, 2017

They weren't exposed publicly, but AFAIK we now no longer have any CoreOS Go style guide. Ideally the non-controversial parts of the README would remain available somewhere.

andrestc added a commit to andrestc/tectonic-installer that referenced this pull request Jan 26, 2018
As per coreos/docs#1142, coreos golang code
style has been removed from cores/docs, this commit rewrites the
code style recommendatin to link to the one maintained by
the go community.
andrestc added a commit to andrestc/tectonic-installer that referenced this pull request Jan 26, 2018
As per coreos/docs#1142, coreos golang code
style has been removed from cores/docs. This commit rewrites the
code style recommendation to link to the one maintained by
the go community.
cpanato pushed a commit to coreos/tectonic-installer that referenced this pull request Feb 14, 2018
As per coreos/docs#1142, coreos golang code
style has been removed from cores/docs. This commit rewrites the
code style recommendation to link to the one maintained by
the go community.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants