This repository was archived by the owner on Feb 5, 2020. It is now read-only.
Add a simple label to the tectonic-system namespace for NetworkPolicy#2898
Merged
cpanato merged 1 commit intocoreos:masterfrom Feb 7, 2018
Merged
Add a simple label to the tectonic-system namespace for NetworkPolicy#2898cpanato merged 1 commit intocoreos:masterfrom
tectonic-system namespace for NetworkPolicy#2898cpanato merged 1 commit intocoreos:masterfrom
Conversation
|
Can one of the admins verify this patch? |
squat
approved these changes
Feb 5, 2018
Contributor
|
ok to test |
Author
|
Test failures seem odd and unrelated? |
Contributor
|
yes, I will re run those |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkPolicy can only select external namespaces by labels, not by name. So add a
namelabel.