Skip to content
This repository was archived by the owner on Feb 5, 2020. It is now read-only.

Azure: add German locations to fault domain map#2368

Merged
squat merged 1 commit intocoreos:masterfrom
2color:patch-1
Feb 15, 2018
Merged

Azure: add German locations to fault domain map#2368
squat merged 1 commit intocoreos:masterfrom
2color:patch-1

Conversation

@2color
Copy link

@2color 2color commented Nov 13, 2017

Purpose

Set the default fault domain count for Germany

Approach

Although not documented in https://docs.microsoft.com/en-us/azure/virtual-machines/windows/manage-availability, I faced the same problems as in #2211.

Where did they keys come from:

az account list-locations
[
  {
    "displayName": "Germany Central",
    "id": "/subscriptions/xxxxxxxxx/locations/germanycentral",
    "latitude": "50.117",
    "longitude": "8.683",
    "name": "germanycentral",
    "subscriptionId": null
  },
  {
    "displayName": "Germany Northeast",
    "id": "/subscriptions/xxxxxxxxx/locations/germanynortheast",
    "latitude": "51.333",
    "longitude": "12.383",
    "name": "germanynortheast",
    "subscriptionId": null
  }
]

Related Issues

Fixes #2211

@coreosbot
Copy link

Can one of the admins verify this patch?

1 similar comment
@coreosbot
Copy link

Can one of the admins verify this patch?

squat
squat previously approved these changes Nov 13, 2017
Copy link
Contributor

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @alexsomesan PTAL

@alexsomesan
Copy link
Contributor

Awesome! Thanks! those weren't even listed in the docs page I linked in there.

alexsomesan
alexsomesan previously approved these changes Nov 13, 2017
@squat
Copy link
Contributor

squat commented Nov 13, 2017

one of the tests timed out. retesting.

@squat
Copy link
Contributor

squat commented Nov 13, 2017

We are running into some resource quota issues in some regions. We are merging a PR that changes the test regions to some with higher limits then we can re-test.

@squat
Copy link
Contributor

squat commented Nov 16, 2017

ok to test

@cpanato
Copy link
Contributor

cpanato commented Feb 2, 2018

retest this please

@cpanato
Copy link
Contributor

cpanato commented Feb 2, 2018

@2color can you please rebase? thanks!

@sym3tri
Copy link
Contributor

sym3tri commented Feb 14, 2018

@cpanato mind taking over and doing the rebase for @2color ?

@squat squat merged commit 6a4cb40 into coreos:master Feb 15, 2018
@2color
Copy link
Author

2color commented Feb 15, 2018

Thanks!
warnerarchive-classic-film-deep-in-my-heart-3oEduXIOiuWkvUNnva

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants