Skip to content

metal/testiso: Also support installs via coreos-installer iso embed #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 24, 2020
Merged

metal/testiso: Also support installs via coreos-installer iso embed #1268

openshift-merge-robot merged 2 commits into from
Mar 24, 2020

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Mar 20, 2020

Confusingly, the testiso command was (is) actually testing PXE installs.
It still does, but now the platform/metal infrastructure has a new
API to do an install via an ISO (scripting embedding an Ignition
config with coreos-installer iso embed).

@cgwalters
Copy link
Member Author

cgwalters commented Mar 20, 2020

Still WIP; I need to track down why my console is going away.

Depends #1258

This was referenced Mar 20, 2020
Closed
Merged
@cgwalters cgwalters force-pushed the testiso-actually-iso branch from 2fe6076 to c892c81 Compare March 20, 2020 22:00
@cgwalters cgwalters changed the title WIP: metal/testiso: Also support installs via coreos-installer iso embed metal/testiso: Also support installs via coreos-installer iso embed Mar 20, 2020
@cgwalters
Copy link
Member Author

cgwalters commented Mar 20, 2020

OK cool, got this to work!

$ cosa kola -- testiso -PS
...
Successfully tested ISO live installer for 31.20200320.dev.3

@cgwalters
Copy link
Member Author

cgwalters commented Mar 20, 2020 •
edited
Loading

Depends:

@cgwalters cgwalters force-pushed the testiso-actually-iso branch 2 times, most recently from 4b18b2a to 0680c97 Compare March 23, 2020 18:10
@cgwalters cgwalters force-pushed the testiso-actually-iso branch from 0680c97 to 5db517c Compare March 23, 2020 18:13
@cgwalters cgwalters force-pushed the testiso-actually-iso branch from 5db517c to 7f4a571 Compare March 23, 2020 18:51
@cgwalters
metal/testiso: Also support installs via coreos-installer iso embed
d3f4d9d 
Confusingly, the `testiso` command was (is) actually testing PXE installs.
It still does, but now the `platform/metal` infrastructure has a new
API to do an install via an ISO (scripting embedding an Ignition
config with `coreos-installer iso embed`).
@cgwalters
metal/testiso: Don't inherit console by default, log cp errors
9cfd6be 
The console is useful for debugging but in the success path
is way too verbose.  What we really want to do is hook into
the console the same way main kola tests do.  That will
come in the future.

Also log errors from `cp` since that's happening in CI (probably
`ENOSPC`); and try to fix that by setting `TMPDIR` in CI.
@cgwalters cgwalters force-pushed the testiso-actually-iso branch from 7f4a571 to 9cfd6be Compare March 24, 2020 13:47
@cgwalters
Copy link
Member Author

cgwalters commented Mar 24, 2020

https://jenkins-coreos-ci.apps.ci.centos.org/blue/organizations/jenkins/github-ci%2Fcoreos%2Fcoreos-assembler/detail/PR-1268/9/pipeline/60

+ set -xeuo pipefail
+ cd /srv
++ pwd
+ env TMPDIR=/srv/tmp/ cosa kola testiso -S
qemu path: builds/31.20200324.dev.0/x86_64/fedora-coreos-31.20200324.dev.0-qemu.x86_64.qcow2.gz
kola --cosa-build builds/31.20200324.dev.0/x86_64/meta.json --output-dir tmp/kola testiso -S
Successfully tested PXE live installer for 31.20200324.dev.0
Successfully tested ISO live installer for 31.20200324.dev.0

🎉

@cgwalters
Copy link
Member Author

cgwalters commented Mar 24, 2020

This is just part of a journey - a next step is noted in this comment around supporting executing all kola tests (plus arbitrary Ignition) conveniently via something like kola run -p qemu --qemu-provision [pxe|iso] or so.
After we have that I think testiso would boil down to a wrapper around that.

@jlebon
Copy link
Member

jlebon commented Mar 24, 2020

Very nice, this is providing much needed coverage!
/approve

Leaving it open in case anyone else wants to review.

@ashcrow
Copy link
Member

ashcrow commented Mar 24, 2020

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ashcrow,cgwalters,jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 17c3b12 into coreos:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgilbert bgilbert Awaiting requested review from bgilbert

1 more reviewer

@ashcrow ashcrow ashcrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashcrow ashcrow

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cgwalters @jlebon @ashcrow @openshift-ci-robot @openshift-merge-robot