mantle: Move core metal logic into platform/, use for testiso #1231
Conversation
|
Depends on #1228 |
|
Hmm, I thought maybe adding the |
|
🏄♂️ Rebased |
arithx
left a comment
arithx
left a comment
There was a problem hiding this comment.
Apologies if there's comments on code that already existed. The diff isn't very useful for me.
|
Not related to this change but i noticed that when I tested the Fedora CoreOS live image, the CoreOS installer failed complaining about finding a signature file. Should we add |
use |
i was doing a |
|
Updated to address comments! |
Today `kola testiso` is pretty hardcoded. I think it was @slowrie suggested making things more generic, and this implements that. The core mantle `platform/` bits have an API to start a PXE install, and the precise Ignition that gets passed in is provided by a higher level test. I also cleaned things up a bit in preparation for supporting ISO testing and not just the PXE path. (Though the code is still messy in this respect, but this is a preparatory step) A possible next step here is to actually implement the `Machine` interface instead of having a custom `InstalledMachine`, that'd make it even easier to have something like: `kola run --pxe basic`
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arithx, cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
Today
kola testisois pretty hardcoded. I think it was @arithxsuggested making things more generic, and this implements
that. The core mantle
platform/bits have an API to starta PXE install, and the precise Ignition that gets passed in
is provided by a higher level test.
I also cleaned things up a bit in preparation for supporting
ISO testing and not just the PXE path. (Though the code
is still messy in this respect, but this is a preparatory step)
A possible next step here is to actually implement the
Machineinterface instead of having a custom
InstalledMachine, that'dmake it even easier to have something like:
kola run --pxe basic